Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable / disable communication #76

Open
cvanbrederode opened this issue Apr 20, 2021 · 2 comments
Open

Enable / disable communication #76

cvanbrederode opened this issue Apr 20, 2021 · 2 comments

Comments

@cvanbrederode
Copy link
Contributor

I have a very specific feature request for a product our company has produced. I implemented it (and changing the Unit ID) easily enough, but thought I would add an issue. I can issue a PR with my version of it if needed.

The ability to turn communication on and off with a function call. Our product doesn't communicate at start up until a digital in is raised, then it talks on ID 1. When the digital in is lowered, it switches to a different ID according to a register. This allows us daisy chain multiple units together without having to pre-configure them; the master gives them each an address in turn.

My fix was a simple private bool, and some methods to toggle it. If the bool is false, processing of packets would stop before checking the unit Id.

@yaacov
Copy link
Owner

yaacov commented Apr 20, 2021

hi, thank you for the issue

a pull request with the feature will be very welcome.

@cvanbrederode
Copy link
Contributor Author

Pull request created. Had to get back into work to test the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants