When does onChange prop get called in React Tagify?

[seanyu4296]

Prerequisites

• I am running the latest version
• I checked the documentation and found no answer
• I checked to make sure that this issue has not already been filed

Demo Page

https://codesandbox.io/s/tagify-react-wrapper-4gkio?file=/src/CrazyTags.js:2696-2704

• in this example, onChange never gets called. I think the question also is what's the best practice for using Tagify in react

Explanation

• What is the expected behavior?
  The expected behavior is when data change in the Tags component. onChange gets called so i can create a controlled input based from React's state
• What is happening instead?
  onChange never seemed to get called
• What error message are you getting?
  None

[yairEO]

Looking into it

[yairEO]

I see there is a big problem with recent React changes:

facebook/react#11488

[seanyu4296]

Thank you for the fast response. Do you think there is a possible solution that maybe I can help with? I can look into it on Monday. @yairEO

[ruberuvalcaba]

Hi @yairEO, I noticed that after this update, callbacks are not returning originalInput.value in mix-mode, it is technically the same output string we get on onChange, but it is more consistent at any point when handling data updates on callbacks like keydown, blur, dropdown:select etc

Output:
e.detail.tagify.DOM.originalInput.value: ""

I'd be nice to keep it

[Maazansari]

Hi @yairEO , I am facing issue with values in onChange callback. I am using MixedTags component with custom tag template.
initially tag renders fine. but after changing anything in text-area, Actual value does not return in onChange call back.

Actual value: {my_custom_tag}
Initially render tag:

Value After making changes:

As you can see value contain next line characters and spaces. If i replace MixedTags with Tag this work perfectly fine.