fix(authors): Revert "feat(authors): scrape authors from github"

This reverts commit e5c9ddf.
diplodoc-platform · Apr 12, 2023 · 7c807ce · 7c807ce
1 parent 5ba12ea
commit 7c807ce
Show file tree

Hide file tree

Showing 10 changed files with 20 additions and 122 deletions.
diff --git a/src/constants.ts b/src/constants.ts
@@ -110,7 +110,6 @@ export const REGEXP_INCLUDE_FILE_PATH = /(?<=[(]).+(?=[)])/g;
 // Include example: author: authorLogin
 // Regexp result: authorLogin
 export const REGEXP_AUTHOR = /(?<=author:\s).+(?=\r?\n)/g;
-export const REGEXP_CONTRIBUTORS = /(?<=contributors:\s).+(?=\r?\n)*?/g;
 
 export const MIN_CHUNK_SIZE = Number(process.env.MIN_CHUNK_SIZE) || 1000;
 export const WORKERS_COUNT = Number(process.env.WORKERS_COUNT) || (os.cpus().length - 1);

diff --git a/src/models.ts b/src/models.ts
@@ -171,8 +171,6 @@ export interface Contributor {
     login: string;
     name: string;
     url: string;
-    date?: string;
-    hash?: string;
 }
 
 export interface Contributors {

diff --git a/src/services/authors.ts b/src/services/authors.ts
@@ -1,62 +1,24 @@
-import os from 'os';
-
-import {logger, replaceDoubleToSingleQuotes} from '../utils';
-import {REGEXP_AUTHOR, REGEXP_CONTRIBUTORS} from '../constants';
+import {replaceDoubleToSingleQuotes} from '../utils';
+import {REGEXP_AUTHOR} from '../constants';
 import {VCSConnector} from '../vcs-connector/connector-models';
-import {isEarlier, parseDataFromJSONString} from './utils';
-import {Contributor} from '../models';
-
-
-export function getContributorArrayFromMetadata(metadata: string[], filePath = '') {
-    const contributors: Contributor[] = [];
-
-    for (const meta of metadata) {
-        const matchContributors = meta.match(REGEXP_CONTRIBUTORS);
-        try {
-            if (matchContributors) {
-                contributors.push(...parseDataFromJSONString(matchContributors[0]));
-            }
-        } catch (err) {
-            logger.warn(filePath, JSON.stringify(err));
-        }
-    }
-
-    return contributors;
-}
 
-
-async function updateAuthorMetadataString(
-    fileMetadata = '',
-    vcsConnector?: VCSConnector,
-    newMetadatas: string[] = [],
-): Promise<string> {
+async function updateAuthorMetadataString(defaultMetadata = '', vcsConnector?: VCSConnector): Promise<string> {
     if (!vcsConnector) {
-        return fileMetadata;
+        return defaultMetadata;
     }
 
-    const matchAuthor = fileMetadata.match(REGEXP_AUTHOR);
+    const matchAuthor = defaultMetadata.match(REGEXP_AUTHOR);
 
     if (matchAuthor && matchAuthor?.length > 0) {
         const authorLogin = matchAuthor[0];
         const user = await getAuthorDetails(vcsConnector, authorLogin);
 
         if (user) {
-            return fileMetadata.replace(authorLogin, user);
-        }
-    }
-
-    const contributors = getContributorArrayFromMetadata(newMetadatas);
-
-    if (contributors.length && !matchAuthor) {
-        contributors.sort((a, b) => isEarlier(a.date, b.date) ? -1 : 1);
-        const user = await getAuthorDetails(vcsConnector, contributors[0]);
-
-        if (user) {
-            return `${fileMetadata}${os.EOL}author: ${user}`;
+            return defaultMetadata.replace(authorLogin, user);
         }
     }
 
-    return fileMetadata;
+    return defaultMetadata;
 }
 
 async function getAuthorDetails(vcsConnector: VCSConnector, author: string | object): Promise<string | null> {

diff --git a/src/services/metadata.ts b/src/services/metadata.ts
@@ -95,11 +95,7 @@ async function getContentWithUpdatedDynamicMetadata(
         const [, fileMetadata, , fileMainContent] = matches;
         let updatedDefaultMetadata = '';
 
-        updatedDefaultMetadata = await updateAuthorMetadataString(
-            fileMetadata,
-            options.vcsConnector,
-            newMetadatas,
-        );
+        updatedDefaultMetadata = await updateAuthorMetadataString(fileMetadata, options.vcsConnector);
 
         return `${getUpdatedMetadataString(newMetadatas, updatedDefaultMetadata)}${fileMainContent}`;
     }

diff --git a/src/services/utils.ts b/src/services/utils.ts
@@ -2,7 +2,6 @@ import evalExp from '@doc-tools/transform/lib/liquid/evaluation';
 import {Filter, TextItems} from '../models';
 import liquid from '@doc-tools/transform/lib/liquid';
 import {ArgvService} from './index';
-import {replaceSingleToDoubleQuotes} from '../utils';
 
 export interface FilterFilesOptions {
     resolveConditions?: boolean;
@@ -150,19 +149,3 @@ export function liquidField(input: string, vars: Record<string, unknown>, path:
 export function isObject(o: unknown): o is object {
     return typeof o === 'object' && o !== null;
 }
-
-export function isEarlier(oldDate?: string, newDate?: string) {
-    if (!newDate) {
-        return false;
-    }
-
-    if (!oldDate) {
-        return true;
-    }
-
-    return new Date(oldDate) > new Date(newDate);
-}
-
-export function parseDataFromJSONString(dataString: string) {
-    return JSON.parse(replaceSingleToDoubleQuotes(dataString));
-}
diff --git a/src/utils/markup.ts b/src/utils/markup.ts
@@ -117,7 +117,3 @@ export function joinSinglePageResults(singlePageResults: SinglePageResult[], roo
 export function replaceDoubleToSingleQuotes(str: string): string {
     return str.replace(/"/g, '\'');
 }
-
-export function replaceSingleToDoubleQuotes(str: string): string {
-    return str.replace(/'/g, '"');
-}
diff --git a/src/vcs-connector/connector-models.ts b/src/vcs-connector/connector-models.ts
@@ -51,7 +51,6 @@ export interface GithubCommitDTO {
         author: {
             name: string;
             email: string;
-            date: string;
         };
     };
     author: {

diff --git a/src/vcs-connector/github.ts b/src/vcs-connector/github.ts
@@ -17,7 +17,6 @@ import {
 } from '../constants';
 import {addSlashPrefix, execAsync, logger} from '../utils';
 import {validateConnectorFields} from './connector-validator';
-import {isEarlier} from '../services/utils';
 
 const contributorsByPath: Map<string, FileContributors> = new Map();
 const contributorsData: Map<string, Contributor | null> = new Map();
@@ -147,7 +146,6 @@ async function getContributorDataByHashCommit(httpClientByToken: Octokit, hashCo
         login,
         name: commit.author.name,
         url,
-        date: commit.author.date,
     };
 }
 
@@ -190,36 +188,18 @@ function addContributorForPath(paths: string[], newContributor: Contributors, ha
                 contributors: newContributor,
                 hasIncludes,
             });
-
             return;
         }
 
         const oldContributors = contributorsByPath.get(normalizePath);
-        const newContributorKey = Object.keys(newContributor)?.[0];
 
-        if (newContributorKey) {
-            const contributors = {
+        contributorsByPath.set(normalizePath, {
+            contributors: {
                 ...oldContributors?.contributors,
                 ...newContributor,
-            };
-
-            if (!oldContributors?.contributors?.[newContributorKey]) {
-                contributorsByPath.set(normalizePath, {
-                    contributors,
-                    hasIncludes,
-                });
-            } else if (
-                isEarlier(
-                newContributor[newContributorKey]?.date,
-                oldContributors?.contributors[newContributorKey]?.date,
-                )
-            ) {
-                contributorsByPath.set(normalizePath, {
-                    contributors,
-                    hasIncludes,
-                });
-            }
-        }
+            },
+            hasIncludes,
+        });
     });
 }
 

diff --git a/tests/integrations/services/metadataContributors.test.ts b/tests/integrations/services/metadataContributors.test.ts
@@ -1,4 +1,3 @@
-import os from 'os';
 import {readFileSync} from 'fs';
 import {normalize} from 'path';
 import {metadataBorder} from '../../../src/constants';
@@ -86,8 +85,6 @@ describe('getContentWithUpdatedMetadata (Contributors)', () => {
                 [contributorFirst.email]: contributorFirst,
                 [contributorSecond.email]: contributorSecond,
             };
-            const expectedAuthorString: string = replaceDoubleToSingleQuotes(
-                JSON.stringify(contributorFirst));
             const expectedContributorsArray: Contributor[] = Object.values(expectedContributors);
             const expectedContributorsString: string =
                 replaceDoubleToSingleQuotes(JSON.stringify(expectedContributorsArray));
@@ -102,7 +99,7 @@ describe('getContentWithUpdatedMetadata (Contributors)', () => {
 
             const splitedFiledContent = fileContent.split(metadataBorder);
             splitedFiledContent[1] =
-                `${splitedFiledContent[1]}${os.EOL}author: ${expectedAuthorString}${os.EOL}contributors: ${expectedContributorsString}${сarriage}`;
+                `${splitedFiledContent[1]}contributors: ${expectedContributorsString}${сarriage}`;
             const expectedFileContent = splitedFiledContent.join(metadataBorder);
             expect(updatedFileContent).toEqual(expectedFileContent);
         });
@@ -119,8 +116,6 @@ describe('getContentWithUpdatedMetadata (Contributors)', () => {
             const expectedContributors: Contributors = {
                 [contributorFirst.email]: contributorFirst,
             };
-            const expectedAuthorString: string = replaceDoubleToSingleQuotes(
-                JSON.stringify(contributorFirst));
             const expectedContributorsArray: Contributor[] = Object.values(expectedContributors);
             const expectedContributorsString: string =
                 replaceDoubleToSingleQuotes(JSON.stringify(expectedContributorsArray));
@@ -135,7 +130,7 @@ describe('getContentWithUpdatedMetadata (Contributors)', () => {
 
             const splitedFiledContent = fileContent.split(metadataBorder);
             splitedFiledContent[1] =
-                `${splitedFiledContent[1]}${os.EOL}author: ${expectedAuthorString}${os.EOL}contributors: ${expectedContributorsString}${сarriage}`;
+                `${splitedFiledContent[1]}contributors: ${expectedContributorsString}${сarriage}`;
             const expectedFileContent = splitedFiledContent.join(metadataBorder);
             expect(updatedFileContent).toEqual(expectedFileContent);
         });
@@ -200,8 +195,7 @@ describe('getContentWithUpdatedMetadata (Contributors)', () => {
                 `and includes files and ${item.title}`, async () => {
                 const expectedContributorsString: string = replaceDoubleToSingleQuotes(
                     JSON.stringify(item.expectedContributorsArray));
-                const expectedAuthorString: string = replaceDoubleToSingleQuotes(
-                    JSON.stringify(contributorFirst));
+
                 metaDataOptions.vcsConnector.getContributorsByPath = (path: string) => Promise.resolve({
                     contributors: getFileContributors(path),
                     hasIncludes: item.getHasIncludes(path),
@@ -213,7 +207,7 @@ describe('getContentWithUpdatedMetadata (Contributors)', () => {
 
                 const splitedFiledContent = fileContent.split(metadataBorder);
                 splitedFiledContent[1] =
-                    `${splitedFiledContent[1]}${os.EOL}author: ${expectedAuthorString}${os.EOL}contributors: ${expectedContributorsString}${сarriage}`;
+                    `${splitedFiledContent[1]}contributors: ${expectedContributorsString}${сarriage}`;
                 const expectedFileContent = splitedFiledContent.join(metadataBorder);
                 expect(updatedFileContent).toEqual(expectedFileContent);
             });

diff --git a/tests/units/services/authors.test.ts b/tests/units/services/authors.test.ts
@@ -99,10 +99,7 @@ describe('updateAuthorMetadataString', () => {
         test('when "defaultMetadata" is empty', async () => {
             const expectedMetadata = '';
 
-            const authorDetails = await updateAuthorMetadataString(
-                expectedMetadata, 
-                defaultVCSConnector,
-            );
+            const authorDetails = await updateAuthorMetadataString(expectedMetadata, defaultVCSConnector);
 
             expect(authorDetails).toEqual(expectedMetadata);
         });
@@ -114,10 +111,7 @@ describe('updateAuthorMetadataString', () => {
 
             defaultVCSConnector.getUserByLogin = () => Promise.resolve(null);
 
-            const updatedMetadata = await updateAuthorMetadataString(
-                expectedMetadata, 
-                defaultVCSConnector,
-            );
+            const updatedMetadata = await updateAuthorMetadataString(expectedMetadata, defaultVCSConnector);
 
             expect(updatedMetadata).toEqual(expectedMetadata);
         });
@@ -131,10 +125,7 @@ describe('updateAuthorMetadataString', () => {
             const authorDetails = units.replaceDoubleToSingleQuotes(JSON.stringify(author));
             defaultVCSConnector.getUserByLogin = () => Promise.resolve(author);
 
-            const updatedMetadata = await updateAuthorMetadataString(
-                defaultMetadata, 
-                defaultVCSConnector,
-            );
+            const updatedMetadata = await updateAuthorMetadataString(defaultMetadata, defaultVCSConnector);
 
             const matchAuthor = defaultMetadata.match(REGEXP_AUTHOR);
             const expectedMetadata = defaultMetadata.replace(matchAuthor[0], authorDetails);