Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: yapplabs/ember-modal-dialog
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.3.0
Choose a base ref
...
head repository: yapplabs/ember-modal-dialog
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.4.0
Choose a head ref
  • 16 commits
  • 32 files changed
  • 8 contributors

Commits on Jul 3, 2017

  1. update imports

    @mazondo
    mazondo committed Jul 3, 2017
    Configuration menu
    Copy the full SHA
    b7da88d View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2017

  1. do not use Ember's function prototype extensions in keyboard example 

    let's prefer prefer `didInsertElement()` and `willDestroyElement()` over the .on() syntax
see: https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-function-prototype-extensions.md
    @caseywatts
    caseywatts authored Jul 17, 2017
    Configuration menu
    Copy the full SHA
    74c84d4 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2017

  1. Fixed formatting on ember install ember-tether

    @djones
    djones authored Jul 19, 2017
    Configuration menu
    Copy the full SHA
    df0a534 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2017

  1. Merge pull request #204 from outdoorsy/master 

    Update imports for newer Ember-cli
    @lukemelia
    lukemelia authored Sep 16, 2017
    Configuration menu
    Copy the full SHA
    8241aae View commit details
    Browse the repository at this point in the history

  2. Merge pull request #209 from djones/master 

    Fixed formatting on `ember install ember-tether`
    @lukemelia
    lukemelia authored Sep 16, 2017
    Configuration menu
    Copy the full SHA
    579b723 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #208 from caseywatts/patch-1 

    keyboard example - use Ember best practice form instead of .on()
    @lukemelia
    lukemelia authored Sep 16, 2017
    Configuration menu
    Copy the full SHA
    2e88ad1 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2017

  1. use new modules api

    @Dhaulagiri
    Dhaulagiri committed Sep 17, 2017
    Configuration menu
    Copy the full SHA
    754e797 View commit details
    Browse the repository at this point in the history

  2. add eslint-plugin-ember and enable new-module-imports rule

    @Dhaulagiri
    Dhaulagiri committed Sep 17, 2017
    Configuration menu
    Copy the full SHA
    0cc5571 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #215 from Dhaulagiri/br-mod 

    use new modules api
    @lukemelia
    lukemelia authored Sep 17, 2017
    Configuration menu
    Copy the full SHA
    37e50b6 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2017

  1. add array defaults before joining them

    @RustyToms
    RustyToms committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    0213768 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2017

  1. Make optional dependencies section easier to read

    @chrisvdp
    chrisvdp authored Sep 29, 2017
    Configuration menu
    Copy the full SHA
    2f5fa8d View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2017

  1. Add ember-cli-version-checker as a dep

    @samselikoff
    samselikoff committed Nov 4, 2017
    Configuration menu
    Copy the full SHA
    16f5d6b View commit details
    Browse the repository at this point in the history

  2. Merge pull request #222 from samselikoff/add-version-checker-as-depen… 

    …dency

Add ember-cli-version-checker as a dep
    @samselikoff
    samselikoff authored Nov 4, 2017
    Configuration menu
    Copy the full SHA
    a14f0a3 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2017

  1. Merge pull request #220 from chrisvdp/patch-1 

    Make optional dependencies section easier to read
    @lukemelia
    lukemelia authored Nov 12, 2017
    Configuration menu
    Copy the full SHA
    a4b0e8b View commit details
    Browse the repository at this point in the history

  2. Merge pull request #217 from RustyToms/fix_ie 

    fix(#195): provide default values for concatenatedProperties
    @lukemelia
    lukemelia authored Nov 12, 2017
    Configuration menu
    Copy the full SHA
    7fa5f39 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2017

  1. Released v2.4.0

    @lukemelia
    lukemelia committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    d10c888 View commit details
    Browse the repository at this point in the history
Loading