-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing issues with chalk@2 #59
Comments
@coreyfarrell is introducing ansi codes to the beginning and end of each line an intentional change in I'm more concerned about the updated version of |
chalk/chalk#92 looks intentional to deal with an OSX terminal bug. Both issues need to be fixed so cliui can update everything, but I've opened chalk/wrap-ansi#32 to add a failing test case. That would fix I have a feeling that the wrap-ansi fix will correct both issues. |
@bcoe I was correct. I tested cliui with all dependencies updated then applied chalk/wrap-ansi#33, no test failures. Once that is merged / released I'll submit a PR to update cliui. It will cause node.js 6 to be required but that should be fine since yargs already requires the same. |
@coreyfarrell sounds good, will happily accept this patch. |
@bcoe my patch yesterday accidentally updated string-width to 4.1.0 which requires node.js 8, now fixed to only upgrade to string-width 3.1.0. Bonus: once this is merged and yargs is updated |
I've tested cliui against newer dependencies, upgrading chalk to 2.x causes a test failure:
I've tested the following script:
Result from
chalk@^1.1.2
:Result from
chalk@^2.4.2
:So the big difference is that
chalk@2
adds ansi codes to the start/end of each line. Upgradingwrap-ansi
to the latest didn't fix the testing errors, it actually caused more errors though I'm unsure if this is due to an issue withwrap-ansi
or withcliui
.The text was updated successfully, but these errors were encountered: