Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect preview of nested bulleted list #1044

Closed
thdoan opened this issue Nov 18, 2021 · 6 comments
Closed

Incorrect preview of nested bulleted list #1044

thdoan opened this issue Nov 18, 2021 · 6 comments
Labels
Area: List editing List editing: continuation, numbering, toggling, etc. Issue: Question Markdown dialect Neither GFM, nor extensions currently accepted. Res: External Outside of our control/codebase.

Comments

@thdoan
Copy link

thdoan commented Nov 18, 2021

Problem

Nested list indented by three spaces looks fine in the extension preview, but it wraps to one line in Bitbucket README.md.

How to reproduce

  1. Create a dummy repo with this README.md file in Bitbucket:
1. Level one
   - Level two
   - Level two
2. Level one
3. Level one
  1. Toggle the extension's Markdown: Open Preview to the Side.
  2. Observe that the preview looks fine in VS Code.
  3. Commit the changes and push to the repo.
  4. Go to the repo index in Bitbucket.

ISSUE: The "Level two" bullets are on the same line as the first "Level one" bullet. It seems Bitbucket requires four spaces to nest lists. According to https://commonmark.org/help/tutorial/10-nestedLists.html you can have as little as two spaces to indicate a nested list, so can we conclude that Bitbucket's MD implementation is non-standard? If this is a case, feel free to close this ticket.

Configuration

Default

Environment

Extension v3.4.0

VS Code
Version: 1.62.1
Commit: f4af3cbf5a99787542e2a30fe1fd37cd644cc31f
Date: 2021-11-05T09:23:14.144Z
Electron: 13.5.2
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 21.1.0

Diagnostic data

N/A

@yzhang-gh
Copy link
Owner

Looks just fine in the GitHub comment.

@thdoan
Copy link
Author

thdoan commented Nov 19, 2021

@yzhang-gh my bad, it was in Bitbucket, not GitHub. I have updated the issue details.

@Lemmingh Lemmingh added Area: List editing List editing: continuation, numbering, toggling, etc. Issue: Question Markdown dialect Neither GFM, nor extensions currently accepted. Res: External Outside of our control/codebase. and removed Needs More Info Needs Reproduction Cannot reproduce. labels Nov 19, 2021
@Lemmingh
Copy link
Collaborator

Bitbucket uses Python-Markdown not CommonMark. Python-Markdown requires "4 spaces" indentation:

Please set the following in your Settings.

{
    "[markdown]": {
        "editor.detectIndentation": false,
        "editor.insertSpaces": true,
        "editor.tabSize": 4
    },
    "markdown.extension.list.indentationSize": "inherit"
}

@B3DTech
Copy link

B3DTech commented Mar 7, 2022

This should be added as a setting inside the settings UI rather than a manual edit to the settings json file to make it easier on users to find.

@B3DTech
Copy link

B3DTech commented Mar 7, 2022

The settings weren't showing until I manually added them to the settings.json. Then they showed up. Strange glitch maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: List editing List editing: continuation, numbering, toggling, etc. Issue: Question Markdown dialect Neither GFM, nor extensions currently accepted. Res: External Outside of our control/codebase.
Projects
None yet
Development

No branches or pull requests

4 participants