Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Optional item tags when maps are put in item frames ! #46

Open
ashitoman opened this issue Mar 11, 2018 · 2 comments
Open

[Request] Optional item tags when maps are put in item frames ! #46

ashitoman opened this issue Mar 11, 2018 · 2 comments
Labels
Feature Issues or PR that bring new ideas or new features.

Comments

@ashitoman
Copy link

ashitoman commented Mar 11, 2018

hi, can you add this option in config to set optional true o false
at least when the map is a single map, to let read to the players a title when the cursor is over a map on an item frame

I'm checking your code but I'm not an expert to modify

https://github.com/zDevelopers/ImageOnMap/blob/1b90fb5e293a2106debe986016ea95bbe42f1494/src/main/java/fr/moribus/imageonmap/ui/MapItemManager.java
sin titulo

I do not want to offend you but I could donate you $ 10 for this

@AmauryCarrade
Copy link
Member

4.0-pre1 (including 1.13 and 1.14 support) has been released! This portion of the code has been updated so the title is kept if non-default (i.e. if you rename a map through an anvil, the name will be displayed on hover). Is this what you were looking for?

This is not supported for splatter maps, but such support could be added.

@AmauryCarrade AmauryCarrade added the Feature Issues or PR that bring new ideas or new features. label Nov 15, 2019
@Vlammar Vlammar added this to the Version 4.1 milestone Feb 17, 2020
@Vlammar
Copy link
Member

Vlammar commented Jun 4, 2020

That's a good Idea you got here. I can scrap a part of what i have donne for links in map. I use an edit tool like paper to highlight map selection i can use this to select some part of the map and with a command /maps select -n texttohoover change text that is hoover on part of the map

@Vlammar Vlammar removed this from the Version 4.1 milestone Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issues or PR that bring new ideas or new features.
Projects
None yet
Development

No branches or pull requests

3 participants