Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Players can break the map and dupe them. #80

Open
Xsm0deus opened this issue Apr 27, 2020 · 4 comments
Open

Players can break the map and dupe them. #80

Xsm0deus opened this issue Apr 27, 2020 · 4 comments
Labels
Bug Ono, a bug!

Comments

@Xsm0deus
Copy link

If you break a part of a full map without shift clicking it then place it on another item frame and shift click it you can get the full map (Check your EntityDamageByEntityEvent cancel)

@TheNety
Copy link

TheNety commented Apr 27, 2020

Maybe would be good to make it permission based. So only players with permission (probably just for server staff) can break parts of the map without shift clicking, so they can crop the image ingame. Anyway idk how much difficult it would be to make it permission based - if it is, it's not really needed to do that.

@Vlammar Vlammar added the Bug Ono, a bug! label Apr 27, 2020
@Vlammar Vlammar added this to the Version 5.0 milestone Apr 29, 2020
@Vlammar
Copy link
Member

Vlammar commented Jun 6, 2020

Maybe would be good to make it permission based. So only players with permission (probably just for server staff) can break parts of the map without shift clicking, so they can crop the image ingame. Anyway idk how much difficult it would be to make it permission based - if it is, it's not really needed to do that.

It's not hard at all to make it permission based but that can lead to issue where player don't find how to remove maps.

@Xsm0deus
Copy link
Author

Xsm0deus commented Jun 6, 2020

We had to make a hacky plugin that basically prevents people from right clicking them unless they're shifting. You could simply add a message in the chat when they normally right click saying to shift right click to remove. Or just make it remove all the maps when they right click unless they got that special permission.

@NotStarRift
Copy link

We had to make a hacky plugin that basically prevents people from right clicking them unless they're shifting. You could simply add a message in the chat when they normally right click saying to shift right click to remove. Or just make it remove all the maps when they right click unless they got that special permission.

I'm currently having this same issue. Would it be possible to share the fix?

@Vlammar Vlammar removed this from the Version 5.0 milestone Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Ono, a bug!
Projects
None yet
Development

No branches or pull requests

4 participants