Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Serviceworkers in Isolated Tabs #199

Open
dscrobonia opened this issue Oct 1, 2018 · 6 comments
Open

Multiple Serviceworkers in Isolated Tabs #199

dscrobonia opened this issue Oct 1, 2018 · 6 comments

Comments

@dscrobonia
Copy link
Contributor

Testing with Firefox 62 it appears that instead of a single service worker process shared among all tabs (per domain) there is now a service worker proccess per tab (per domain). Loading new pages within a single tab still keep the same service worker, but openning a new tab spawns a new service worker.

I believe this change still complies with the service worker spec, which defines service workers as stateless, but has broken our model of how we use service workers because of a few hacks we have made to keep the serviceworker performant. This will require some changes to how I had originally mapped out multi tab support, but should still be doable.

I do still need to test on chrome. If the firefox and chrome implementations of service workers has diverged (which I would guess they have) we'll have to consider that as well.

@psiinon
Copy link
Member

psiinon commented Oct 11, 2018

For ref the related Firefox bug is: https://bugzilla.mozilla.org/show_bug.cgi?id=1438945 and the good news is that it looks like it should be fixed soon.

@dscrobonia
Copy link
Contributor Author

Going to look through that thread now 😬 do we know for sure it will solve our serviceworker single process bug? I wasn't totally sure if it was the exact same bug.

@dscrobonia
Copy link
Contributor Author

Alright. I actually just caught up on this thread. Here is a linked, related thread that is specific to the service workers. https://bugzilla.mozilla.org/show_bug.cgi?id=1429805

I just added a comment to it, but @psiinon if you wanted to poke and prod there that would be great.

@dscrobonia
Copy link
Contributor Author

I'm thinking we'll be able to work around this issue. Not 100% sure yet, but hopeful. Ideally Firefox would still fix, but we'll see.

@psiinon
Copy link
Member

psiinon commented Apr 12, 2019

So https://bugzilla.mozilla.org/show_bug.cgi?id=1438945 says its fixed in Firefox 65 - we should double check to see if this is all ok now...

@dscrobonia
Copy link
Contributor Author

How exciting! I'll need to investigate...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants