Remove temporary directory flag

[phillebaba]

Describe what should be investigated or refactored

Currently we have a --tmpdir flag in the root command. This allows users to set a custom directory to use for their temp directory.

Using this flag requires use to pass the configured flag every time we want to create a temporary directory.

zarf/src/pkg/packager/sources/url.go

Line 56 in 87dfbcd

tmp, err := utils.MakeTempDir(config.CommonOptions.TempDirectory)

There is already a standard to override the temporary directory used by go when creating a new directory.

On Unix systems, it returns $TMPDIR if non-empty, else /tmp.
On Windows, it uses GetTempPath, returning the first non-empty value from %TMP%, %TEMP%, %USERPROFILE%, or the Windows directory.

We should remove the flag and tell people to use these environment variables instead if they want to override the temp directory. We should also remove use to the helpers function to create the temporary directory in favor of stdlib.

Links to any relevant code

zarf/src/cmd/root.go

Line 131 in 87dfbcd

rootCmd.PersistentFlags().StringVar(&config.CommonOptions.TempDirectory, "tmpdir", v.GetString(common.VTmpDir), lang.RootCmdFlagTempDir)