Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove #[allow(clippy::duplicated_attributes)] after rustc nightly-2024-04-22 or later #1328

Open
sea212 opened this issue Apr 30, 2024 · 1 comment
Open

Remove #[allow(clippy::duplicated_attributes)] after rustc nightly-2024-04-22 or later #1328

sea212 opened this issue Apr 30, 2024 · 1 comment
Labels
l:XS Solving this issue takes minutes p:low Low priority, resolution of this issue can wait t:maintenance The issue describes necessary maintenance
Milestone
v0.6.0

Comments

@sea212
Copy link
Member

sea212 commented Apr 30, 2024 •
edited
Loading

See rust-lang/rust-clippy#12537. Currently we can't use that rustc version or later, because it results in errors.

Occurrences:

zeitgeist/primitives/src/math/fixed.rs

Lines 333 to 334 in b958393

// TODO(#1328): Remove after rustc nightly-2024-04-22
#![allow(clippy::duplicated_attributes)]

zeitgeist/primitives/src/math/root.rs

Lines 159 to 160 in b958393

// TODO(#1328): Remove after rustc nightly-2024-04-22
#![allow(clippy::duplicated_attributes)]

zeitgeist/zrml/neo-swaps/src/math.rs

Lines 508 to 509 in b958393

// TODO(#1328): Remove after rustc nightly-2024-04-22
#![allow(clippy::duplicated_attributes)]

zeitgeist/zrml/swaps/src/tests.rs

Lines 27 to 28 in b958393

// TODO(#1328): Remove after rustc nightly-2024-04-22
#![allow(clippy::duplicated_attributes)]

@sea212 sea212 added p:low Low priority, resolution of this issue can wait t:maintenance The issue describes necessary maintenance labels Apr 30, 2024
@sea212 sea212 changed the title Remove #[allow(clippy::duplicated_attributes)] after rustc > nightly-2024-04-22 Remove #[allow(clippy::duplicated_attributes)] after rustc nightly-2024-04-22 or later Apr 30, 2024
@sea212 sea212 mentioned this issue Apr 30, 2024
Merged
@maltekliemann maltekliemann added this to the v0.5.4 milestone May 3, 2024
@maltekliemann maltekliemann added the l:XS Solving this issue takes minutes label May 3, 2024
@saboonikhil
Copy link
Member

The required changes can be implemented only after #1331 is realised on main.

@maltekliemann maltekliemann modified the milestones: v0.5.4, v0.6.0 Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
l:XS Solving this issue takes minutes p:low Low priority, resolution of this issue can wait t:maintenance The issue describes necessary maintenance
Projects
None yet
Milestone
v0.6.0
Development

No branches or pull requests
3 participants
@sea212 @saboonikhil @maltekliemann