-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade go-redis to v9 #3088
Conversation
wait for redis v9 fix race bug redis/go-redis#2557 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
@kevwan This issue has been pending for a long time, so we need to find a way to bypass it. We can split go test command into two parts: normal test and race test:
|
2c4a0a5
to
964ce8d
Compare
go-redis fixed race issue in v9.3.1 redis/go-redis#2814, we only need upgrade version now. |
Hook
interface changesfix test failure, waiting v9 to fix data race bugsplit go test into two parts: normal and race, to bypass redis v9 race issuego.mod
ingoctl
, but depends on go-zero release