-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(goctl): multi imports the api cause redeclared error in types.go #3988
Conversation
2cbfc8d
to
2c44d37
Compare
Plz describe which issue scenario should be fix |
Hi @kesonan, you can check the added test cases to understand that the specific scenario is in a gateway that has the following referenced relationship:
Use |
e703b9d
to
93ef7e4
Compare
Hi @kesonan , I still have this problem with the latest code in master branch, please check the contents of the |
8e22d08
to
fd9802b
Compare
Sorry, it should be that the title of the PR is not expressed clearly enough, and the redeclared error appears in the |
Is the problem fixed already? |
@kevwan Unfortunately the code on master still has this problem now, and this pr is designed to fix it. |
02a1f8d
to
bfc3018
Compare
bfc3018
to
a4d3fb6
Compare
pls execute the following cmd |
@kesonan Okay, this is the output of the
btw, something that could potentially have an impact on this is the value of the |
I retested with the latest code on master, as well as executing $ env | grep GOCTL
# nothing
$ ./goctl env
GOCTL_OS=darwin
GOCTL_ARCH=arm64
GOCTL_HOME=/Users/jayson/.goctl
GOCTL_DEBUG=False
GOCTL_CACHE=/Users/jayson/.goctl/cache
GOCTL_EXPERIMENTAL=on
GOCTL_VERSION=1.6.3
PROTOC_VERSION=
PROTOC_GEN_GO_VERSION=v1.33.0
PROTO_GEN_GO_GRPC_VERSION=1.3.0 |
Yes, after I executed |
a4d3fb6
to
54a5ebc
Compare
@kesonan PTAL. |
@wjiec Please add my WeChat account and we can communicate on WeChat. The efficiency here is a bit low. WeChat ID is |
54a5ebc
to
010213f
Compare
7ff7fb2
to
9bbf16f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8b2964a
to
28ae09c
Compare
Now experimental features are turned on by default in Goctl, is this correct?
go-zero/tools/goctl/pkg/env/env.go
Lines 79 to 81 in c7dacb0