Oracle dialect

[fwbrasil]

The dialect creation itself is simple, the hard part is have integration tests in place for it.

[ghisvail]

Is anyone working on an Oracle JDBC dialect?

If not, how hard would it be?

[deusaquilus]

I started working on this earlier tonight and to say it's a pain is an understatement. While Oracle does have a docker image, you need a dockerhub login in order access it ,which now means that we need to manage dockerhub credentials in travis.

On top of that, it's practically impossible to pull down SQL-Plus into our debian setup image in any automated way, and we need some kind of CLI client in order to create the initial quill_test database. So I opted to go the jdbc/maven route with sqlline, only to find that Oracle doesn't post artifacts to maven-central but has their own exclusive maven repo that requires special OTN credentials (Oracle Technology Network, i.e. the same Oracle-Specific account you need to download previous versions of Java).

The way this build is shaping up, you need both an OTN account as well as a DockerHub account in order to be able to use the Oracle Docker Image to run the test suites.

This leaves two questions that need to be answered?

1. Is it a realistic expectation for all our comitters to sign up for both an OTN account as well as a DockerHub account, just to be able to run our integration suite on their local machine?
2. If not, should we introduce flags into Dockerfile-setup and setup_local.sh which will disable to the parts related to oracle? The only alternative to this is managing two sets of docker/build files.

[jilen]

Maybe oracle express edition could be used for test purpose
https://github.com/wnameless/docker-oracle-xe-11g

[deusaquilus]

I'm trying to do away with the OTN credentials, maybe docker-compose health checks or an intermediate container can do the waiting part (maybe even wait until the quill database is constructed). I'd like to use the official image since we can actually expect updates to happen on it in a normal cadence.

[deusaquilus]

Please continue discussion on #1295

[deusaquilus]

Oracle has started issuing DMCA takedown notices on unofficial Docker containers that everyone relies on. This has an impact on our ability to support Oracle in an upcoming release. To anyone who wants Oracle support in Quill's future, please chime on on #1295.