New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inaccurate comment about VerifyingComment::ic #88

Open

daira opened this issue Jul 5, 2022 · 0 comments

Contributor

daira commented Jul 5, 2022

bellman/src/groth16/mod.rs

Lines 124 to 128 in 9bb30a7

    
           // Elements of the form (beta * u_i(tau) + alpha v_i(tau) + w_i(tau)) / gamma 
        
           // for all public inputs. Because all public inputs have a dummy constraint, 
        
           // this is the same size as the number of inputs, and never contains points 
        
           // at infinity. 
        
           pub ic: Vec<E::G1Affine>,

$\tau$ is the toxic waste, this should say it's the corresponding G1 elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment