Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iframe sidebar sometimes overlaps other content #35

Open
Su-Well opened this issue Oct 10, 2018 · 1 comment
Open

Iframe sidebar sometimes overlaps other content #35

Su-Well opened this issue Oct 10, 2018 · 1 comment

Comments

@Su-Well
Copy link

Su-Well commented Oct 10, 2018

I've seen this on several sites, the most recent in memory being youtube.com, where Sidebar+ is on top of youtube's menu on the left:
image

It's my opinion that this isn't really Sidebar+'s fault, but rather the fault of bad CSS on the offending websites. Case in point, even youtube's own devs refers to the overlapping element's CSS as:
image

Nevertheless, it is our problem. I've played around with Sidebar+'s and youtube's CSS a little, but have as of yet been unable to find a solution I'm confident can be generalized to all sites. I'm not very skilled at CSS, but here are some things that come to mind as far as solutions go:

  • Due to the diversity of of sites this has to work on, I seriously doubt this can be solved solely by editing the CSS of the parent sidebar element
  • Maybe there is a way to trick the main site into thinking the screen starts?
  • Maybe the sidebar can be placed in a separate parent element, as a sibling to the main element?
  • Another option is to inspect the properties of all direct children of , and modify the CSS of those that would overlap Sidebar+

I'd be happy to put in some work on this, but I figure that I should at least get your thoughts on this first @zluca.

@zluca
Copy link
Owner

zluca commented Oct 10, 2018

Problem is that the more you touch site CSS the more chance to broke something. In earlier versions of Sidebar+ we had more aggressive CSS inception and it destroy some sites functionality.

One of the ways is to make a specific CSS rules for the most popular sites like Youtube to adopt it for Sidebar+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@zluca @Su-Well and others