Skip to content

Commit

Permalink
Merge branch 'main' into feature-versioning
Browse files Browse the repository at this point in the history
  • Loading branch information
sarahs committed Jun 22, 2021
2 parents 4c0e21e + 76042bb commit 1188fa5
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 1 deletion.
2 changes: 1 addition & 1 deletion middleware/contextualizers/generic-toc.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ module.exports = async function genericToc (req, res, next) {
async function getTocItems (pagesArray, context, isRecursive, renderIntros) {
return (await Promise.all(pagesArray.map(async (child) => {
// Do not include hidden child items on a TOC page
if (child.page.hidden) return
if (child.page.hidden && !context.currentPath.includes('/early-access/')) return

return {
title: child.renderedFullTitle,
Expand Down
24 changes: 24 additions & 0 deletions tests/unit/early-access.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
const fs = require('fs').promises
const path = require('path')
const { testViaActionsOnly } = require('../helpers/conditional-runs')
const { getDOM } = require('../helpers/supertest')
const got = require('got')

describe('cloning early-access', () => {
testViaActionsOnly('the content directory exists', async () => {
Expand All @@ -18,3 +20,25 @@ describe('cloning early-access', () => {
expect(await fs.stat(eaDir)).toBeTruthy()
})
})

describe('rendering early-access', () => {
jest.setTimeout(5 * 60 * 1000)

testViaActionsOnly('the top-level TOC renders locally', async () => {
const $ = await getDOM('/en/early-access')
expect($.html().includes('Hello, local developer! This page is not visible on production.')).toBe(true)
expect($('ul a').length).toBeGreaterThan(5)
})

testViaActionsOnly('the top-level TOC does not render on production', async () => {
async function getEarlyAccess () {
return await got('https://docs.github.com/en/early-access')
}
await expect(getEarlyAccess).rejects.toThrowError('Response code 404 (Not Found)')
})

testViaActionsOnly('TOCs display on category pages', async () => {
const $ = await getDOM('/en/early-access/github/enforcing-best-practices-with-github-policies')
expect($('ul a').length).toBeGreaterThan(5)
})
})

0 comments on commit 1188fa5

Please sign in to comment.