Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 user property #89

Merged
merged 2 commits into from
Jan 1, 2024
Merged

feat: 🎸 user property #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c56a960
feat: 🎸 user property
tomokisun Jan 1, 2024
ac83682
feat: 🎸 onboard completed
tomokisun Jan 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Packages/BeMatch/Sources/AnalyticsKeys/UserPropertyKeys.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ public extension UserPropertyKeys {
var id: String { "id" }
var gender: String { "gender" }
var username: String { "username" }
var onboardCompleted: String { "onboard_completed" }
}
1 change: 1 addition & 0 deletions Packages/BeMatch/Sources/AppFeature/AppLogic.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ public struct AppLogic {
Reduce<State, Action> { state, action in
switch action {
case .view(.onboard(.path(.element(_, .capture(.delegate(.nextScreen)))))):
analytics.setUserProperty(key: \.onboardCompleted, value: "true")
state.view = .navigation()
return .none
case .view(.navigation(.match(.setting(.delegate(.toEditProfile))))):
Expand Down
2 changes: 2 additions & 0 deletions Packages/BeMatch/Sources/GenderSettingFeature/GenderSetting.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import AnalyticsClient
import AnalyticsKeys
import BeMatch
import BeMatchClient
import ComposableArchitecture
Expand Down Expand Up @@ -72,6 +73,7 @@ public struct GenderSettingLogic {

case .updateGenderResponse(.success):
state.isActivityIndicatorVisible = false
analytics.setUserProperty(key: \.gender, value: state.selection?.rawValue)
return .send(.delegate(.nextScreen))

case .updateGenderResponse(.failure):
Expand Down
2 changes: 2 additions & 0 deletions Packages/BeMatch/Sources/UsernameSettingFeature/UsernameSetting.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import AnalyticsClient
import AnalyticsKeys
import BeMatch
import BeMatchClient
import ComposableArchitecture
Expand Down Expand Up @@ -63,6 +64,7 @@ public struct UsernameSettingLogic {

case .updateBeRealResponse(.success):
state.isActivityIndicatorVisible = false
analytics.setUserProperty(key: \.username, value: state.username)
return .send(.delegate(.nextScreen))

case .updateBeRealResponse(.failure):
Expand Down