Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Always validate callback signatures & add support for EIP-1271 signatures #1885

Merged

Commits on Jun 24, 2019

  1. Configuration menu
    Copy the full SHA
    05c6024 View commit details
    Browse the repository at this point in the history
  2. @0x/base-contract: Make PromiseWithTransactionHash fully compatib…

    …le with regular `Promise` types.
    
    `@0x/contracts/exchange` Make `OrderValidator` and `WalletOrderValidator` signature types checked for every fill (not just first)'
    dorothy-zbornak committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    d835071 View commit details
    Browse the repository at this point in the history
  3. @0x/contracts-exchange: Always check OrderValidator and `WalletOr…

    …derValidator` signature types on every fill
    
    `@0x/contracts-exchange`: Add `validatorAddress` field to `SignatureValidatorError` and `SignatureOrderValidatorError` rich reverts
    `@0x/contracts-exchange`: Add separate `SignatureOrderValidatorNotApprovedError` for `OrderValidator` signatures
    `@0x/contracts-exchange`: Consolidate Wallet and Validator test contracts into a single configurable `TestValidatorWallet` contract.
    `@0x/contracts-exchange`: Rewrite many tests in `signature_validator.ts` for brevity.
    dorothy-zbornak committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    4e86c53 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b1439cd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a9e1a26 View commit details
    Browse the repository at this point in the history
  6. @0x/order-utils: Add validator field to `SignatureOrderValidatorE…

    …rror` and `SignatureValidatorError` `RevertError` types.
    
    `@0x/order-utils`: Add `SignatureOrderValidatorNotApprovedError` and `SignatureValidatorNotApprovedError` `RevertError` types.
    dorothy-zbornak committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    ce6f447 View commit details
    Browse the repository at this point in the history
  7. @0x/contracts-exchange: Have TestValidatorWallet always accept `W…

    …alletOrderValidator` if `makerAddress == this`.
    
    `@0x/contracts-exchange`: Update tests for repeatable signature validation.
    dorothy-zbornak committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    18cc4b7 View commit details
    Browse the repository at this point in the history
  8. @0x/types: Rename WalletOrderValidator to OrderWallet in `Signa…

    …tureType`
    
    `@0x/types`: Add `EIP1271Wallet` and `EIP1271OrderWallet` to `SignatureType`
    dorothy-zbornak committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    cad5dd8 View commit details
    Browse the repository at this point in the history
  9. @0x/order-utils: Rename SignatureWalletOrderValidatorError to `Si…

    …gnatureOrderWalletError` `RevertError` type.
    dorothy-zbornak committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    89ca1e0 View commit details
    Browse the repository at this point in the history
  10. @0x/contracts-exchange: Rename WalletOrderValidator to `OrderWall…

    …et` signature type
    
    `@0x/contracts-exchange`: Rename `SignatureWalletOrderValidatorError` to `SignatureOrderWalletError`
    `@0x/contracts-exchange`: Add `IEIP1271Wallet` interface
    `@0x/contracts-exchange`: Add `EIP1271Wallet` and `EIP1271OrderWallet` to `SignatureType`
    `@0x/contracts-exchange`: Always check `OrderValidator`, `OrderWallet`, `EIP1271OrderWallet` signature types on every fill
    `@0x/contracts-exchange`: Add tests for EIP1271 signature types.
    `@0x/contracts-exchange`: Update `LibExchangeRichErrorDecoder` for new/renamed Error types.
    dorothy-zbornak committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    577a721 View commit details
    Browse the repository at this point in the history
  11. Run prettier/linter

    dorothy-zbornak committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    81f6265 View commit details
    Browse the repository at this point in the history
  12. Update changelogs

    dorothy-zbornak committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    56dbaa5 View commit details
    Browse the repository at this point in the history
  13. Rebase against 3.0

    dorothy-zbornak committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    0e9d1cf View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2019

  1. Configuration menu
    Copy the full SHA
    d5623cf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e3c4442 View commit details
    Browse the repository at this point in the history
  3. @0x/contracts-exchange: Refactor out EIP1271_MAGIC_VALUE into a `…

    …LibEIP1271` contract and inherit from that.
    
    `@0x/contracts-exchange`: Use `LibBytes.readBytes4()` to validate EIP1271 return values and be more permissive of shorter return values.
    `@0x/contracts-exchange`: Use `abi.decode()` for `EIP1271OrderWallet` in `TestSignatureValidator.sol`.
    `@0x/contracts-exchange`: Correct minor formatting changes in contracts.
    dorothy-zbornak committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    c6761b2 View commit details
    Browse the repository at this point in the history
  4. @0x/contracts-exchange: Add comments about preserving signatures in…

    … `MixinSignatureValidator.sol`
    dorothy-zbornak committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    6093a73 View commit details
    Browse the repository at this point in the history
  5. Fix linter errors

    dorothy-zbornak committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    1186820 View commit details
    Browse the repository at this point in the history
  6. @0x/contracts-exchange: Consolidate signature types.

    `@0x/contracts-exchange`: Fighting with linearization issues.
    dorothy-zbornak committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    24b21ed View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    acdcb1b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c0aa42b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c08a618 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. @0x/contracts-exchange: Add isValidHashSignature() back.

    `@0x/contracts-exchange`: Remove references to removed signature types and associated functions.
    dorothy-zbornak committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    721de3c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    51638fc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1f28d67 View commit details
    Browse the repository at this point in the history
  4. @0x/contracts-exchange: Update tests for new/consolidated signature…

    … types.
    
    `@0x/contracts-exchange`: Update `Whitelist` example for new signature types.
    dorothy-zbornak committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    13e0433 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3ab8eab View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8e9c185 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a099f05 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e7bde04 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a966abd View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2019

  1. Configuration menu
    Copy the full SHA
    c2f4d45 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    896cd51 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d85e9c7 View commit details
    Browse the repository at this point in the history