-
Notifications
You must be signed in to change notification settings - Fork 466
Always validate callback signatures & add support for EIP-1271 signatures #1885
Always validate callback signatures & add support for EIP-1271 signatures #1885
Commits on Jun 24, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 05c6024 - Browse repository at this point
Copy the full SHA 05c6024View commit details -
@0x/base-contract
: MakePromiseWithTransactionHash
fully compatib……le with regular `Promise` types. `@0x/contracts/exchange` Make `OrderValidator` and `WalletOrderValidator` signature types checked for every fill (not just first)'
Configuration menu - View commit details
-
Copy full SHA for d835071 - Browse repository at this point
Copy the full SHA d835071View commit details -
@0x/contracts-exchange
: Always checkOrderValidator
and `WalletOr……derValidator` signature types on every fill `@0x/contracts-exchange`: Add `validatorAddress` field to `SignatureValidatorError` and `SignatureOrderValidatorError` rich reverts `@0x/contracts-exchange`: Add separate `SignatureOrderValidatorNotApprovedError` for `OrderValidator` signatures `@0x/contracts-exchange`: Consolidate Wallet and Validator test contracts into a single configurable `TestValidatorWallet` contract. `@0x/contracts-exchange`: Rewrite many tests in `signature_validator.ts` for brevity.
Configuration menu - View commit details
-
Copy full SHA for 4e86c53 - Browse repository at this point
Copy the full SHA 4e86c53View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1439cd - Browse repository at this point
Copy the full SHA b1439cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for a9e1a26 - Browse repository at this point
Copy the full SHA a9e1a26View commit details -
@0x/order-utils
: Addvalidator
field to `SignatureOrderValidatorE……rror` and `SignatureValidatorError` `RevertError` types. `@0x/order-utils`: Add `SignatureOrderValidatorNotApprovedError` and `SignatureValidatorNotApprovedError` `RevertError` types.
Configuration menu - View commit details
-
Copy full SHA for ce6f447 - Browse repository at this point
Copy the full SHA ce6f447View commit details -
@0x/contracts-exchange
: HaveTestValidatorWallet
always accept `W……alletOrderValidator` if `makerAddress == this`. `@0x/contracts-exchange`: Update tests for repeatable signature validation.
Configuration menu - View commit details
-
Copy full SHA for 18cc4b7 - Browse repository at this point
Copy the full SHA 18cc4b7View commit details -
@0x/types
: RenameWalletOrderValidator
toOrderWallet
in `Signa……tureType` `@0x/types`: Add `EIP1271Wallet` and `EIP1271OrderWallet` to `SignatureType`
Configuration menu - View commit details
-
Copy full SHA for cad5dd8 - Browse repository at this point
Copy the full SHA cad5dd8View commit details -
@0x/order-utils
: RenameSignatureWalletOrderValidatorError
to `Si……gnatureOrderWalletError` `RevertError` type.
Configuration menu - View commit details
-
Copy full SHA for 89ca1e0 - Browse repository at this point
Copy the full SHA 89ca1e0View commit details -
@0x/contracts-exchange
: RenameWalletOrderValidator
to `OrderWall……et` signature type `@0x/contracts-exchange`: Rename `SignatureWalletOrderValidatorError` to `SignatureOrderWalletError` `@0x/contracts-exchange`: Add `IEIP1271Wallet` interface `@0x/contracts-exchange`: Add `EIP1271Wallet` and `EIP1271OrderWallet` to `SignatureType` `@0x/contracts-exchange`: Always check `OrderValidator`, `OrderWallet`, `EIP1271OrderWallet` signature types on every fill `@0x/contracts-exchange`: Add tests for EIP1271 signature types. `@0x/contracts-exchange`: Update `LibExchangeRichErrorDecoder` for new/renamed Error types.
Configuration menu - View commit details
-
Copy full SHA for 577a721 - Browse repository at this point
Copy the full SHA 577a721View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81f6265 - Browse repository at this point
Copy the full SHA 81f6265View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56dbaa5 - Browse repository at this point
Copy the full SHA 56dbaa5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e9d1cf - Browse repository at this point
Copy the full SHA 0e9d1cfView commit details
Commits on Jun 25, 2019
-
Configuration menu - View commit details
-
Copy full SHA for d5623cf - Browse repository at this point
Copy the full SHA d5623cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3c4442 - Browse repository at this point
Copy the full SHA e3c4442View commit details -
@0x/contracts-exchange
: Refactor outEIP1271_MAGIC_VALUE
into a `……LibEIP1271` contract and inherit from that. `@0x/contracts-exchange`: Use `LibBytes.readBytes4()` to validate EIP1271 return values and be more permissive of shorter return values. `@0x/contracts-exchange`: Use `abi.decode()` for `EIP1271OrderWallet` in `TestSignatureValidator.sol`. `@0x/contracts-exchange`: Correct minor formatting changes in contracts.
Configuration menu - View commit details
-
Copy full SHA for c6761b2 - Browse repository at this point
Copy the full SHA c6761b2View commit details -
@0x/contracts-exchange
: Add comments about preserving signatures in…… `MixinSignatureValidator.sol`
Configuration menu - View commit details
-
Copy full SHA for 6093a73 - Browse repository at this point
Copy the full SHA 6093a73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1186820 - Browse repository at this point
Copy the full SHA 1186820View commit details -
@0x/contracts-exchange
: Consolidate signature types.`@0x/contracts-exchange`: Fighting with linearization issues.
Configuration menu - View commit details
-
Copy full SHA for 24b21ed - Browse repository at this point
Copy the full SHA 24b21edView commit details -
Configuration menu - View commit details
-
Copy full SHA for acdcb1b - Browse repository at this point
Copy the full SHA acdcb1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c0aa42b - Browse repository at this point
Copy the full SHA c0aa42bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c08a618 - Browse repository at this point
Copy the full SHA c08a618View commit details
Commits on Jun 26, 2019
-
@0x/contracts-exchange
: AddisValidHashSignature()
back.`@0x/contracts-exchange`: Remove references to removed signature types and associated functions.
Configuration menu - View commit details
-
Copy full SHA for 721de3c - Browse repository at this point
Copy the full SHA 721de3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 51638fc - Browse repository at this point
Copy the full SHA 51638fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f28d67 - Browse repository at this point
Copy the full SHA 1f28d67View commit details -
@0x/contracts-exchange
: Update tests for new/consolidated signature…… types. `@0x/contracts-exchange`: Update `Whitelist` example for new signature types.
Configuration menu - View commit details
-
Copy full SHA for 13e0433 - Browse repository at this point
Copy the full SHA 13e0433View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ab8eab - Browse repository at this point
Copy the full SHA 3ab8eabView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e9c185 - Browse repository at this point
Copy the full SHA 8e9c185View commit details -
Configuration menu - View commit details
-
Copy full SHA for a099f05 - Browse repository at this point
Copy the full SHA a099f05View commit details -
@0x/contracts-exchange
: MakeassertValidFill
and `calculateMatche……dFillResults` public
Configuration menu - View commit details
-
Copy full SHA for e7bde04 - Browse repository at this point
Copy the full SHA e7bde04View commit details -
Configuration menu - View commit details
-
Copy full SHA for a966abd - Browse repository at this point
Copy the full SHA a966abdView commit details
Commits on Jul 1, 2019
-
Configuration menu - View commit details
-
Copy full SHA for c2f4d45 - Browse repository at this point
Copy the full SHA c2f4d45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 896cd51 - Browse repository at this point
Copy the full SHA 896cd51View commit details -
Configuration menu - View commit details
-
Copy full SHA for d85e9c7 - Browse repository at this point
Copy the full SHA d85e9c7View commit details