This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Always validate order signatures #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorothy-zbornak
approved these changes
Oct 5, 2019
contracts/exchange/test/core.ts
Outdated
| @@ -230,7 +230,7 @@ blockchainTests.resets('Exchange core', () => { | |||
| signedOrder = await orderFactory.newSignedOrderAsync(); | |||
| }); | |||
|
|
|||
| describe('repeatable signature types', () => { | |||
| describe('signature types', () => { | |||
There was a problem hiding this comment.
Suggested change
| describe('signature types', () => { | |
| describe('callback signature types', () => { |
| /// @param signature The signature for `hash`. | ||
| /// @return needsRegularValidation True if the signature should be validated | ||
| /// for every action. | ||
| function _doesSignatureRequireRegularValidation( |
jalextowle
approved these changes
Oct 7, 2019
abandeali1
force-pushed
the
fix/3.0/always-validate-signatures
branch
from
932b7f2
to
8b695f9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.Affects 0xProject/ZEIPs/issues/33