Update admin menu icon typography and color #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helen
force-pushed
the
fix/admin-menu-icon
branch
from
1323309
to
0d4f387
Compare
|
Decided to just go with changing the color on the existing one (slightly heavier weight, wider character spacing) for minimal change, since really we want to get rid of this top-level item eventually anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Updates the admin menu icon to use the same font weight as the large logo and have a white background. It's a little thin at that size but I think looks better than before.
Alternate Designs
Could also just fill with white and not change the font weight.
Benefits
More consistent with admin icons.
Possible Drawbacks
n/a
Verification Process
Viewing in admin.
Checklist:
Applicable Issues
Fixes #243
Changelog Entry