Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotes from generated excerpts and modify prompt slightly #468

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented May 26, 2023

Description of the Change

ChatGPT tends to add quotes around things, which is not needed when generating an excerpt. This was caught and fixed while working on the generate titles feature, so adding that same functionality to excerpts.

This PR also slightly tweaks the prompt we use to generate excerpts to try and get better summaries.

How to test the Change

Test out the excerpt generation and ensure excerpts are generated and no quotes are added around the excerpts

Changelog Entry

Changed - Tweak the prompt that is used to generate excerpts
Fixed - Ensure quotes aren't added around generated excerpts

Credits

Props @dkotter

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dkotter dkotter added this to the 2.2.1 milestone May 26, 2023
@dkotter dkotter requested a review from a team as a code owner May 26, 2023 17:37
@dkotter dkotter self-assigned this May 26, 2023
@dkotter dkotter requested a review from jeffpaul as a code owner May 26, 2023 17:37
Copy link
Contributor

@ravinderk ravinderk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove quotes from the excerpt as expected.

image

@dkotter dkotter merged commit 2a4f6b7 into develop Jun 6, 2023
13 checks passed
@dkotter dkotter deleted the fix/excerpt-quotes branch June 6, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants