-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#430: Use proper plurals based on image settings #482
Merged
dkotter
merged 5 commits into
develop
from
feature/430-use-proper-plurals-based-on-image-setting
Jul 6, 2023
Merged
#430: Use proper plurals based on image settings #482
dkotter
merged 5 commits into
develop
from
feature/430-use-proper-plurals-based-on-image-setting
Jul 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e generated automatically.
ravinderk
suggested changes
Jun 8, 2023
@jamesmorrison Thanks for the work here! I've left one comment that I think we should address. There's also a few other text strings that we probably want to update.
|
@dkotter I've reverted to if else (rather than |
dkotter
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adds singular labels where a single image is selected for generation.
Closes #430
How to test the Change
Test 1: Plural:
Enable image generation
is checkedGenerate Images
Enter a prompt below to generate images.
Once images are generated, choose one or more of those to import into your Media Library and then choose one image to insert.
Test 3: Singular:
Enable image generation
is checkedGenerate Images
Enter a prompt below to generate an image.
- newOnce an image is generated, you can import it into your Media Library and then select to insert.
- newChangelog Entry
Credits
Props @jamesmorrison
Checklist: