Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we define the class property before using it #548

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Jul 28, 2023

Description of the Change

As reported, in newer versions of PHP (seems like 8.2+) a PHP deprecation is shown because of our NLU class. We have a class property nlu_features, that we use but never define. This PR fixes that by ensuring that property is defined.

Closes #547

How to test the Change

  1. In an environment running PHP 8.2 and with this PR checked out, ensure no deprecation notices are shown
  2. Ensure all NLU functionality still works
  3. Downgrade to PHP 7.4 and ensure things still work as well

Changelog Entry

Fixed - Ensure we define a class property before using it to avoid PHP deprecation notices

Credits

Props @ankitguptaindia, @dkotter

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dkotter dkotter added this to the 2.3.0 milestone Jul 28, 2023
@dkotter dkotter requested a review from a team as a code owner July 28, 2023 16:08
@dkotter dkotter self-assigned this Jul 28, 2023
@dkotter dkotter requested a review from jeffpaul as a code owner July 28, 2023 16:08
@dkotter dkotter requested review from a team and Sidsector9 and removed request for a team and jeffpaul July 28, 2023 18:22
@Sidsector9 Sidsector9 merged commit fcbe3b0 into develop Jul 31, 2023
12 checks passed
@Sidsector9 Sidsector9 deleted the fix/547 branch July 31, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP Deprecated Notice in Log file on PHP 8.2.8
2 participants