Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support controlling feature availability #614

Merged
merged 7 commits into from
Nov 20, 2023

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Nov 10, 2023

Description of the Change

PR adds an enable/disable feature setting option for the below features. PR also improves the codebase for better maintainability.

  • Language Processing / IBM Watson / Natural Language Understanding
  • Language Processing / Microsoft Azure / Text to Speech
  • Recommended Content / Microsoft Azure / AI Personalizer

Closes #589

Note for the reviewer:
To avoid merge conflict I have started work from enhancement/588 branch and kept it as base branch for this PR.

How to test the Change

  1. Go to Classifai settings for the specific feature.
  2. Toggle feature availability for the below features and verify that feature availability reflects accordingly on site.
  • Language Processing / IBM Watson / Natural Language Understanding
  • Language Processing / Microsoft Azure / Text to Speech
  • Recommended Content / Microsoft Azure / AI Personalizer

Changelog Entry

Added - Enable/disable toggle option for the "Classify content" feature.
Added - Enable/disable toggle option for the "Text to Speech" feature.
Added - Enable/disable toggle option for the "Recommended content" feature.

Credits

Props @iamdharmesh @jeffpaul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh self-assigned this Nov 10, 2023
@iamdharmesh iamdharmesh added this to the 2.5.0 milestone Nov 10, 2023
@iamdharmesh iamdharmesh linked an issue Nov 10, 2023 that may be closed by this pull request
1 task
@iamdharmesh iamdharmesh changed the title [WIP] Add support controlling feature availability Add support controlling feature availability Nov 10, 2023
@iamdharmesh iamdharmesh marked this pull request as ready for review November 10, 2023 12:05
@iamdharmesh iamdharmesh changed the base branch from enhancement/588 to develop November 10, 2023 12:05
@iamdharmesh iamdharmesh changed the base branch from develop to enhancement/588 November 10, 2023 12:06
@dkotter dkotter requested a review from berkod November 13, 2023 21:07
@dkotter dkotter merged commit e51d23c into enhancement/588 Nov 20, 2023
1 check passed
@dkotter dkotter deleted the enhancement/589 branch November 20, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controlling feature availability
3 participants