Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classify content within existing Taxonomy terms #620

Merged
merged 9 commits into from
Dec 7, 2023
Merged

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Nov 22, 2023

Description of the Change

The PR introduces a new setting option in content classification (IBM Watson NLU) to classify content within existing taxonomy terms. By default, it will adhere to the current behavior, recommending and adding new terms to the post. When the user chooses "Only classify based on existing terms" in the classification method, it will recommend terms only from the existing terms.

image

Closes #592

How to test the Change

  1. Go to Tools > ClassifAI > Language Processing > IBM Watson
  2. Choose "Only classify based on existing terms" in the classification method.
  3. Create/Edit the post and click the "Suggest terms & tags" button from the classifAI sidebar panel.
  4. Verify that suggested terms/tags are from the existing terms only.
  5. Go to ClassifAI settings, choose "Add recommended terms " in the classification method and verify that it now suggests new terms/tags as well.
  6. Go to ClassifAI settings, and verify that the results of terms/tags in the language processing previewer are also aligned with the current classification method setting.

Changelog Entry

Added - New setting option in content classification to classify content within existing taxonomy terms

Credits

Props @jeffpaul @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh self-assigned this Nov 22, 2023
@iamdharmesh iamdharmesh changed the title [WIP] Classify content within existing Taxonomies Classify content within existing Taxonomy terms Nov 22, 2023
@iamdharmesh iamdharmesh added this to the 2.6.0 milestone Nov 22, 2023
@iamdharmesh iamdharmesh marked this pull request as ready for review November 22, 2023 18:05
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion

The popup would show the notice,

'Note that the lists above include any pre-existing terms from this %s.',

We should also tweak this notice when the existing terms-based classification setting is enabled. We can tweak to something like:

'Note that the lists above include only pre-existing terms from this %s. You can change this classification method in settings.'

and add a link on the 'settings' text to the settings page.

@iamdharmesh
Copy link
Member Author

@faisal-alvi

We should also tweak this notice when the existing terms-based classification setting is enabled.

I think Note that the lists above include any pre-existing terms from this Post is meant for existing terms of the specific post and not for all existing terms. So, this might not need an update.

@dkotter dkotter modified the milestones: 2.6.0, 2.5.0 Nov 28, 2023
dkotter
dkotter previously approved these changes Nov 28, 2023
@dkotter dkotter requested a review from berkod November 28, 2023 21:08
berkod
berkod previously approved these changes Dec 4, 2023
@jeffpaul jeffpaul mentioned this pull request Dec 6, 2023
22 tasks
@jeffpaul
Copy link
Member

jeffpaul commented Dec 6, 2023

@iamdharmesh @dkotter one item I noticed during UAT today was perhaps a copy tweak, sharing here to see if this resonates with either of you for a quick commit to change before merging this in...

  • Changing Add all suggested terms to Recommend terms even if they do not exist on the site
  • Changing Only add suggested terms that already exist to Only recommend terms that already exist on the site

@dkotter dkotter dismissed stale reviews from berkod and themself via 51e5b7b December 6, 2023 21:46
@dkotter
Copy link
Collaborator

dkotter commented Dec 6, 2023

one item I noticed during UAT today was perhaps a copy tweak, sharing here to see if this resonates with either of you for a quick commit to change before merging this in.

Makes sense to me. Pushed an update for that:

Classification method settings

@dkotter dkotter merged commit 9927b36 into develop Dec 7, 2023
9 of 12 checks passed
@dkotter dkotter deleted the enhancement/592 branch December 7, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Classify content within existing Taxonomies
5 participants