Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/636 Pre Classification Popup terms limit removed #638

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Conversation

faisal-alvi
Copy link
Member

@faisal-alvi faisal-alvi commented Dec 11, 2023

Description of the Change

  • This PR removes the maximum allowed term limit (i.e. 100) in the pre-classification popup.
  • Instead of fetching all the terms on the new term insertion, it just updates the existing term object by adding a new term item to it. This is super helpful in terms of performance. This change was required because after adding a new term, we need to fetch all the terms for the updated term object, but fetching all the terms is not possible (i.e. { per_page: -1 } does not work).

Closes #636

How to test the Change

Make sure the following issues are fixed.

  • The terms beyond 100 are not visible in the pop-up.
  • The terms beyond 100 will not be suggested in the drop downs.
  • Even if the term is already added, it attempts to re-add because it doesn't detect it within 100 terms.
  • When trying to add new terms, it doesn't display the newly added term, even though the term is added to the site.

Also, test the popup; confirm everything related to the popup works.

Changelog Entry

Fixed - Pre Classification Popup Limits to 100 terms

Credits

Props @faisal-alvi @dkotter

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@faisal-alvi faisal-alvi self-assigned this Dec 11, 2023
@faisal-alvi faisal-alvi marked this pull request as ready for review December 11, 2023 15:09
@jeffpaul jeffpaul added this to the 2.5.0 milestone Dec 11, 2023
@dkotter dkotter mentioned this pull request Dec 12, 2023
22 tasks
@dkotter dkotter merged commit 9a9ffca into develop Dec 12, 2023
13 checks passed
@dkotter dkotter deleted the fix/636 branch December 12, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre Classification Popup Limits to 100 terms
3 participants