Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bottom margin to the Classify button if needed #694

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Feb 5, 2024

Description of the Change

When the Classification feature is turned on but the toggle is turned off, a button is shown. If the Text to Speech Feature is turned on, it renders toggles within the same panel and the classification button collides, as it doesn't have any bottom spacing (see screenshot on #664).

This PR fixes that by adding some CSS that adds a bottom margin to the button container but removes that spacing if the button is the last element in the list (to avoid extra spacing when it isn't needed).

Classification button with bottom margin

Closes #664

How to test the Change

  1. Turn on both the Classification Feature and Text to Speech Feature
  2. Edit an item that supports both
  3. Turn off the Automatically tag content on update toggle
  4. Ensure the button that shows has proper bottom spacing

Changelog Entry

Fixed - Ensure the classification button has proper bottom spacing

Credits

Props @dkotter, @QAharshalkadu

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dkotter dkotter added this to the 3.0.0 milestone Feb 5, 2024
@dkotter dkotter self-assigned this Feb 5, 2024
@dkotter dkotter requested review from jeffpaul and a team as code owners February 5, 2024 23:13
@dkotter dkotter removed request for a team and jeffpaul February 5, 2024 23:14
@github-actions github-actions bot added the needs:code-review This requires code review. label Feb 5, 2024
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you @dkotter!

image

@dkotter dkotter merged commit 6f3ca32 into develop Feb 6, 2024
14 checks passed
@dkotter dkotter deleted the fix/664 branch February 6, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
2 participants