Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fatal error in the PDF text extraction from the media row actions. #706

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

iamdharmesh
Copy link
Member

Description of the Change

PR fixes the fatal error reported in #701. Currrently, when we try to extract text from PDF using the media list table row actions. it throws a fatal error. This PR fixes it.

Closes #701

How to test the Change

  1. Go to Media > Add New Media File
  2. Upload PDF file
  3. Go to Media > Library
  4. Switch view mode to list, it will change media view to list table view.
  5. Click on the "Extract text from PDF" action of uploaded PDF file
  6. Verify there is no fatal error and text extracted from the PDF.

Changelog Entry

Fixed - Ensure that the "Extract text from PDF" row action works properly in the media list table.

Credits

Props @qasumitbagthariya @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh requested review from dkotter, jeffpaul and a team as code owners February 9, 2024 11:41
@github-actions github-actions bot added this to the 3.0.0 milestone Feb 9, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Feb 9, 2024
@dkotter dkotter merged commit faae0f0 into develop Feb 9, 2024
13 checks passed
@dkotter dkotter deleted the fix/701 branch February 9, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting Fatal error on the PDF test extraction
2 participants