-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding and settings refactor to React #771
base: develop
Are you sure you want to change the base?
Conversation
@iamdharmesh below, I've checked the "Editor" checkbox under "Allowed roles". Ideally it should have just re-rendered the area pointed by the arrow, but instead the whole App re-renders. We can consider improving this. |
Preventing access of state at the root App may help avoid re-rendering. I am working on and likely to fix this. |
…i into enhancement/react-settings
08e103f
to
b0bd72b
Compare
} ); | ||
|
||
return ( | ||
<Fill name="ClassifAIProviderSettings"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self:
Find out a way to make this easier so that 3rd-party devs don't have to write Fill
.
Maybe try exporting a component on the window
object which can be used to inject custom Provider settings.
Description of the Change
The PR refactors the settings and onboarding to a React-based implementation and deprecates the existing settings panel. The existing settings panel is deprecated but can still be enabled using the
classifai_use_legacy_settings_panel
filter.Closes #502
Closes #449
How to test the Change
Settings:
Tools
>ClassifAI
.develop
branch, then switch to this PR branch. Confirm that no settings are lost and that all data is correctly reflected in the new settings page.add_filter( 'classifai_use_legacy_settings_panel', '__return_true' );
. Verify that the old settings page loads and works as expected.OnBoarding
add_filter( 'classifai_use_legacy_settings_panel', '__return_true' );
. Verify that the old onboarding/setup page loads and works as expected.Add additional feature fields
Add custom Provider fields
General
Run a full regression test to ensure everything is working as expected.
Changelog Entry
Credits
Props @jeffpaul @dkotter @iamdharmesh @Sidsector9
Checklist: