部屋内での複数のカードの位置の同期 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } catch (error) { | ||
| // 設定読み込みエラー | ||
| console.log(error); | ||
| } | ||
| } | ||
| return () => { |
There was a problem hiding this comment.
useEffectの使い方見た感じ、このreturn文cardsQueryResultのuseEffectか、空配列のuseEffectどっちにかいたほうがいいのかね。まあ設定上ありえないんだけど、もしゲーム中にリフェッチまたはポーリングによるクエリの更新があった場合、websocketが一旦切れてしまうおそれがあるという... ただ空配列のuseEffectに入れたら入れたでなんか二重のwebsocketが接続しっぱなしみたいな状況になるｗ
|
あと再直近で移動させたカードのz-indexを最大にする（一番上にもってくる）ほうがいいかも。 |
YasuakiYoshii
approved these changes
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
クライアント，サーバー間でのカード情報送受信シーケンス図
動作確認
サーバー(feature/receive_cards_info)を起動した状態でデッキ作成後，同部屋に2端末で入室し，カードを移動させる
関連するサーバーサイドの変更
部屋内での複数のカードの位置の同期のためのWebSocketメッセージの実装 by bana118 · Pull Request #25 · 2d-rpg/card-playroom-server