This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
Features/missing ref warning instead of error #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rasmus-Rosted
changed the title
Rasmus-Rosted
changed the title
soft_fail parameter in action.yml
soft_fail flag
MindaugasLaganeckas
approved these changes
Jan 22, 2021
| ref: "heads/" + branch | ||
| }) | ||
| } catch (error) { | ||
| const shouldFailSoftly = (soft_fail === 'true'); |
There was a problem hiding this comment.
Can you not have soft_fail as boolean from the start (not as string) in JS?
There was a problem hiding this comment.
I might have misunderstood something, but it does not seem like it from what is described in actions/toolkit#361
Maybe I just haven't looked into it enough
…f-warning-instead-of-error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation gives the user the possibility to decide if the action should fail with an error or continue with a warning. This is done in order to make the action more flexible in the cases where a branch does not exist but the rest of the workflow that the action is used in is not dependent on that condition.