Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove samples #1343

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Remove samples #1343

merged 2 commits into from
Feb 3, 2021

Conversation

TonyCrane
Copy link
Collaborator

@TonyCrane TonyCrane commented Feb 3, 2021

Motivation

Fixes #1330, #1337, #1341, #1342.
On some machines, the line samples=1 will cause pyglet.window.NoSuchConfigException, deleting it (changing it to the default value of 0) will not cause problems.
This is also included in #1336.

Proposed changes

  • Remove samples=1 in window.py

@TonyCrane TonyCrane requested a review from 3b1b February 3, 2021 09:25
@3b1b 3b1b merged commit 0a54145 into 3b1b:master Feb 3, 2021
@TonyCrane TonyCrane deleted the remove-samples branch February 14, 2021 13:30
eulertour pushed a commit to eulertour/manim-3b1b that referenced this pull request Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error after installing manim
2 participants