Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix for zooming #1578

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Minor fix for zooming #1578

merged 1 commit into from
Jul 28, 2021

Conversation

timedilatesme
Copy link
Contributor

@timedilatesme timedilatesme commented Jul 14, 2021

Motivation

It's weird that when you Scroll Up, the interactive shell zooms out, this is generally the other way round for most of the UI's.

Proposed changes

Simply replace factor -> 1 / factor.

It's weird that when you Scroll Up, the interactive shell zooms out.

So to fix this replace factor -> 1/factor .
@TonyCrane
Copy link
Collaborator

I guess this problem is caused by the natural scrolling of the Mac system.

Grant uses MacOS, and the default scrolling in MacOS is natural scrolling, which makes the operation on the touchpad very natural and direct. But if MacOS is connected to an ordinary mouse, the scrolling direction of the mouse wheel will be opposite to that of Windows (Windows is using unnatural scrolling, and the direction is just opposite to that of Mac). At this time, a software is generally installed to reverse the scrolling direction of the mouse. In this case, scrolling up with the mouse is equivalent to scrolling down under normal conditions (including Windows and Mac). Therefore, Grant may be designed like this, so that the mouse on the Mac can achieve the effect of scrolling up to zoom in, but it has caused the problem of scrolling up to zoom out on other systems.

I don’t know if it’s a good idea to judge the OS here, maybe @3b1b should come and have a look?

I am also using a Mac system. I installed the Scroll Reverser software to reverse the direction of the mouse wheel. In other places, I can use the mouse wheel as on the Windows system, and scroll up when I press z to zoom in the scene. So I made this conjecture.

@3b1b
Copy link
Owner

3b1b commented Jul 28, 2021

Honestly, either one works for me.

@3b1b 3b1b merged commit 354db44 into 3b1b:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants