Fix Text wrong display #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eulertour |
TonyCrane
added a commit
to manim-kindergarten/manim
that referenced
this pull request
May 21, 2020
* latex can't recognize path seperator \\ in windows Modify path before transport it to system command * Re-add documentation link * Update README.md * Remove livestreaming option * Display help if no input file is specified * Revise config again (3b1b#987) * Fix Text wrong display (3b1b#889) * Performance improvement for most scenes (3b1b#974) * Fix three bugs(shaders/stroke/size) of Text Class (text_mobject.py) (3b1b#1030) * fix: remove the last M tag in svg files to make Text run in shaders branch * fix: close the svg path manually to fix the bug of wrong stroke * fix: remove Space mobjects in Text to fix the bug of TransformText * feat: make Text and TextMobject equal in size * this will lead to more bugs of setting color, so I delete it * Fix space characters problem of Text (3b1b#1035) * Fix Text wrong display * Fix space characters problem of Text * Fix a potential bug using height or width in Text * Update Text * Fix typo in text_mobject.py * Remove versions from requirements.txt * Fixed ffmpeg 'Impossible to Open' and 'Protocol not found' (3b1b#1057) * Code() in file Code_mobject.py to display code with color highlighted added Paragraph() and "exact_spaces" parameter to Text() (3b1b#1036) * Added DocStrings for all methods in Container, Scene, GraphScene, MovingCameraScene, SceneFileWriter, ThreeDScene, SpecialThreeDScene, ZoomedScene, VectorScene, and LinearTransformationScene. (3b1b#1040) * Added DocStrings for methods in Container and Scene. Removed 2 unused imports from scene.py. * Added DocStrings for all methods in GraphScene, MovingCameraScene, SceneFileWriter, ThreeDScene, SpecialThreeDScene and ZoomedScene. * Added DocStrings for all methods in `VectorScene` and LinearTransformationScene... ...except `position_x_coordinate` and `position_y_coordinate` Co-authored-by: Aathish Sivasubrahmanian <aathishs@Aathishs-MacBook-Air.local> * Remove sanim directory * Fix "itslef" to "itself" I know this is trivial, but I had to fix it. * Add missing import to brace.py Without `import copy` lines 128 to 131 will throw an error. I've tested this edit in my local version of the library and it fixes the bug. * Delete perf_scenes.py Co-authored-by: zombie110year <zombie110year@outlook.com> Co-authored-by: Devin Neal <devin@eulertour.com> Co-authored-by: XiaoYoung <47266984+xy-23@users.noreply.github.com> Co-authored-by: Mike Magruder <mikemag@users.noreply.github.com> Co-authored-by: NavpreetDevpuri <30471072+NavpreetDevpuri@users.noreply.github.com> Co-authored-by: Aathish <aathish04@gmail.com> Co-authored-by: Aathish Sivasubrahmanian <aathishs@Aathishs-MacBook-Air.local> Co-authored-by: applemonkey496 <55333787+applemonkey496@users.noreply.github.com>
eulertour
added a commit
to eulertour/manim-3b1b
that referenced
this pull request
Jan 2, 2021
* Allow for chaining _AnimationBuilder * Add _AnimationBuilder.build() * Apply docs patch * fix play call with multiple .animate for the same mobject Co-authored-by: Benjamin Hackl <devel@benjamin-hackl.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Relevant issues: #884 (comment) & #680 (comment)
I found that since #748 has merged, the
TextMobject was displayed unexpectedly.Behavior
Here is a simple demo reproduce the problem.
(Noticed that
stroke_widthwas set to 1 by default.)Noticed there are some tiny "thorn".
Solution
By setting
TextMobject'sstroke_widthto 0 default.In order to avoid the similar problem, I also set some params to default.