Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calving tutorial notebook from 4DModeller workshop #256

Merged
merged 12 commits into from
May 23, 2024

Conversation

icetianli
Copy link
Contributor

  • Summary of changes (Bug fix, feature, docs update, ...)

  • Please check if the PR fulfills these requirements

  • Closes #xxxx (replace xxxx with the GitHub issue number)
  • Tests added and passed
  • All code checks passing - styler run over code
  • Vignettes updated/added
  • Added an entry in the latest CHANGELOG.md file if fixing a bug or adding a new feature
  • Any new libraries added to DESCRIPTION

@gareth-j gareth-j added documentation Improvements or additions to documentation hackathon-23 labels Nov 17, 2023
@gareth-j gareth-j changed the base branch from main to devel November 17, 2023 16:14
@gareth-j
Copy link
Contributor

@icetianli would you be able to share some of the data you used for this tutorial?

@icetianli
Copy link
Contributor Author

Yeah sure, will do.

@mnky9800n
Copy link
Contributor

I that the reason this is failing is becuase it is using ubuntu-latest but the latest distro of ubuntu on github is not having all the R dependencies as part of the image. i could be wrong.

@mnky9800n
Copy link
Contributor

i still dont know why pkgdown fails. maybe @gareth-j knows.

@mnky9800n
Copy link
Contributor

Error: Error: processing vignette 'covid_mcmc.Rmd' failed with diagnostics:
parse error: premature EOF

i think there is something wrwong with the data download, but it does this for literally all of the tutorials.

@mnky9800n
Copy link
Contributor

@icetianli can you remove the .png files.

@gareth-j gareth-j self-requested a review March 20, 2024 15:06
@gareth-j
Copy link
Contributor

@icetianli can you change the header on the tutorial vignette to match the format of the other vignettes?
It'd be something like this:

---
title: "Simple Linear Regression with fdmr"
output: 
  bookdown::html_document2:
    base_format: rmarkdown::html_vignette
    fig_caption: yes
bibliography: "references.bib"
link-citations: yes
vignette: >
  %\VignetteIndexEntry{Simple Linear Regression with fdmr}
  %\VignetteEngine{knitr::rmarkdown}
  %\VignetteEncoding{UTF-8}
---

@aabelean
Copy link
Contributor

DESCRIPTION does not have tidyverse as an import, does it?

Added `tidyverse` to `DESCRIPTION`
@aabelean
Copy link
Contributor

The pkgdown and ubuntu errors look similar to this StackOverflow question. The OP was also using Ubuntu.

@mnky9800n
Copy link
Contributor

The pkgdown and ubuntu errors look similar to this StackOverflow question. The OP was also using Ubuntu.

Perhaps we have to have the xmatrix import in a different order?

@mnky9800n
Copy link
Contributor

@icetianli i cloned your repo and tried to run your tutorial and it fails when it tries to use the formula because fc is not declared.

image

I am guessing you are trying to use the data column FrontChange so when i replace fc with FrontChange I get this error:

image

tbh, i'm not sure what the id.loc0 variable is doing? it also is not declared. if you remove it, you can get inla to run:

image

@icetianli
Copy link
Contributor Author

Thanks all, will sort this notebook out asap.

@mnky9800n mnky9800n merged commit 42539a3 into 4DModeller:devel May 23, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation hackathon-23
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants