Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OHC tutorial #318

Merged
merged 10 commits into from
Jul 11, 2024
Merged

OHC tutorial #318

merged 10 commits into from
Jul 11, 2024

Conversation

aabelean
Copy link
Contributor

@aabelean aabelean commented Jun 29, 2024

  • Summary of changes (Bug fix, feature, docs update, ...)

  • Please check if the PR fulfills these requirements

  • Tests added and passed
  • All code checks passing - styler run over code
  • Vignettes updated/added
  • Added an entry in the latest CHANGELOG.md file if fixing a bug or adding a new feature

@aabelean aabelean marked this pull request as ready for review July 2, 2024 16:14
@aabelean aabelean requested a review from mnky9800n July 3, 2024 08:28
Copy link
Contributor

@mnky9800n mnky9800n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i pulled the repo and got an error trying to knit the tutorial:

! object 'ocean_crs' not found

should we add this to the repo or the data repository?

@aabelean
Copy link
Contributor Author

aabelean commented Jul 10, 2024

i pulled the repo and got an error trying to knit the tutorial:

! object 'ocean_crs' not found

should we add this to the repo or the data repository?

I think it doesn't load the polygon we used to create ocean_crs. Could you run the cell where we load the dataset and see if it loads?

That said, I cannot reproduce this error as it knits without issue on all devices I have.

@mnky9800n
Copy link
Contributor

I figured out the issue and it was because i needed devtools::load_all(). but this shouldn't be true for normal users.

@mnky9800n mnky9800n merged commit 398852b into devel Jul 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants