Fix examples/hello test round#2 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 23, 2022 14:29
I forgot to check whether the result is `IMAGE_SYNTH_SUCCESS`.
61315
added
bug
61315
reviewed
Feb 23, 2022
| echo "\033[1;92mTest Passed!\033[0m"; \ | ||
| else \ | ||
| echo "\033[1;91mTest Failed!\033[0m"; \ | ||
| exit 1; \ |
There was a problem hiding this comment.
examples/hello.c with no change
Testing...
IMAGE_SYNTH_SUCCESS
Test Passed!
Done!
examples/hello.c with an empty mask
diff --git a/examples/hello.c b/examples.hello.c
- mask_image_data[i * HEIGHT + j] = 0xFF;
+ mask_image_data[i * HEIGHT + j] = 0x00;Testing...
IMAGE_SYNTH_ERROR_EMPTY_TARGET
Test Failed!
make: *** [test] Error 1
examples/hello.c with indexing beyond array boundaries
diff --git a/examples/hello.c b/examples.hello.c
- mask_image_data[i * HEIGHT + j] = 0xFF;
+ mask_image_data[i * HEIGHT * HEIGHT + j] = 0xFF;Testing...
/bin/sh: line 1: 12061 Segmentation fault: 11 examples/hello
Test Failed!
make: *** [test] Error 1
61315
reviewed
Feb 23, 2022
| @@ -2,7 +2,7 @@ | |||
| CC = clang -std=c99 | |||
| CPPFLAGS = -MMD -MP -DSYNTH_LIB_ALONE | |||
| CFLAGS = -Wall -Wextra -pedantic -O3 | |||
| LDFLAGS = | |||
| LDFLAGS = -lm | |||
There was a problem hiding this comment.
This is very helpful.
I really didn't understand before why there has to be the -lm flag. Thanks!
Why do you have to link the math library in C?
61315
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to check whether the result is
IMAGE_SYNTH_SUCCESS.Also add GitHub continuous integration for macos and ubuntu. (I only tested on macos.)
closes #1