Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UIP-3]: Fix pool reward streaming #3

Merged
merged 3 commits into from
Jan 27, 2021
Merged

Conversation

8quad
Copy link
Owner

@8quad 8quad commented Jan 26, 2021

Universal Improvement Proposal 3:

  • This proposal is about fixing an issue with fluctuating rewards balances showing up. This issue was found by community members that found an inconsistency between the original Empty Set Dollar logic and our novel streaming implementation.
  • Minor update: not allowed to cancel all stream reserved in pool bond function (as originally done in DAO bond).
  • Also implemented UIP-2.

An new DAO instance implementing these changes is deployed at:
0xE620699ecD0f20c0B89029F5d51D95B14090C8CB

An new Pool instance implementing these changes is deployed at:
0x352bD56cBF56f192c4922C9695c25bBB48EbfE56

We would like to give our special thanks to @lebeda for helping analyze and find the issue. @lebeda will be rewarded 25 U8D for this contribution. 0x75E3744f61513A016036b2F1c327eD4aA7073f73

@8quad 8quad merged commit 7633dee into master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant