feat: removeDuplicateTags() validates tags and panic with meaningful …

[gitxiongpan]

if schema defines a bad goTag, example:

type AObject {
    id: ObjectID! @goTag(key: "bson", value: "_id, omitempty")
}

The value contains an empty space. This will break removeDuplicateTags function and panic with vague error message which makes it hard to debug.

My PR checks goTag format and panic with meaningful message which helps debugging a lot.

Before:

After:

Test result:

I have:

• [✅] Added tests covering the bug / feature (see testing)
• [❌ ] Updated any relevant documentation (see docs)

[coveralls]

Coverage: 75.417% (+0.009%) from 75.408% when pulling 4bf2616 on gitxiongpan:master into 677d854 on 99designs:master.

[StevenACoffman]

In general, I would prefer if we did not panic, but since we already did, this is a big improvement to at least give a good reason! Thanks very much!

[emanuel-gjini]

@gitxiongpan It looks like this update actually broke one of my running servers due to the usage of some tags that are used to generate GORM model tags. And some of those actually have spaces, like this one for example (from the gql schema):

type Proxy @private {
  id: Uint! @goTag(key: "gorm", value: "primaryKey")
  ip: String! @goTag(key: "gorm", value: "unique;not null")
}

Notice the not null

Is there any chance we can allow spaces in tag values?

[gitxiongpan]

@emanuel-gjini I am sorry for what happened to you. In fact, it was broken before my PR, by other contributor.
have a look of that removeDuplicateTags()
func removeDuplicateTags(t string) string { processed := make(map[string]bool) tt := strings.Split(t, " ")

I totally understand your frustration. I have just submitted a PR to fix this issue. #2628

[emanuel-gjini]

@gitxiongpan Many thanks for the fix ❤️