Fix 2546: Federation 2 Relax external for object #2599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Coffman <steve@khanacademy.org>
StevenACoffman
changed the title
StevenACoffman
added a commit
that referenced
this pull request
Mar 30, 2023
Signed-off-by: Steve Coffman <steve@khanacademy.org>
StevenACoffman
added a commit
that referenced
this pull request
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2546
@externalwas originally (Federation v1) only applicable onFIELD_DEFINITION.Federation v2 relaxed directive definition to also allow applying it on
OBJECT(which has the same effect as making all the object fields as@external).The specs for v2 indicate that it is allowed on objects: https://www.apollographql.com/docs/federation/subgraph-spec/.
directive @external on FIELD_DEFINITION | OBJECTA dig through the source of gqlgen resulted in this:gqlgen/plugin/federation/federation.go
Line 93 in db1e3b8
Signed-off-by: Steve Coffman steve@khanacademy.org