feat(federation): update Apollo Federation v2 definitions #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Apollo Federation v2 directive definitions: * `_FieldSet` was renamed `FieldSet` * new `@composeDirective` (fed v2.1 change) * `@shareable` is now repeatable (fed v2.2 change) * new `@interfaceObject` directive (fed v2.3 change) NOTE: definitions are updated to the latest Federation v2 spec. Users might specify old version import (i.e. `@link` import v2.0) trying to use new federation features (e.g. `@interfaceObject`) which may lead to potential composition errors (i.e. server starts up fine but cannot be federated into a "supergraph").
| directive @external on FIELD_DEFINITION | ||
| scalar _Any |
There was a problem hiding this comment.
This line is still shared by both v1 and v2, correct?
There was a problem hiding this comment.
yeah but I thought it was cleaner to keep v1 and v2 definitions separate so they can be ordered (only common parts are @extends and _Any)
|
@dariuszkuc Thanks for this contribution! |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Apollo Federation v2 directive definitions:
_FieldSetwas renamed toFieldSet@composeDirective(fed v2.1 change)@shareableis now repeatable (fed v2.2 change)@interfaceObjectdirective (fed v2.3 change)NOTE: definitions are updated to the latest Federation v2 spec. Users might specify old version import (i.e.
@linkimport v2.0) trying to use new federation features (e.g.@interfaceObject) which may lead to potential composition errors (i.e. server starts up fine but cannot be federated into a "supergraph").I have: