Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reworked integration testing using vitest #2675

Merged
merged 3 commits into from
Jun 15, 2023
Merged

Reworked integration testing using vitest #2675

merged 3 commits into from
Jun 15, 2023

Conversation

UnAfraid
Copy link
Contributor

@UnAfraid UnAfraid commented Jun 14, 2023 •
edited
Loading

Added SSE client to integration testing
Fixed SSE Transport parse errors not being sent as event-stream
Added URQL client to test @defer feature (Seems broken on apollo client)

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@UnAfraid
Reworked integration using vitest
f21e526 
Added SSE client testing
Fixed SSE Transport parse errors not being sent as event-stream
@coveralls
Copy link

Coverage Status

coverage: 75.559% (-0.4%) from 75.935% when pulling f21e526 on UnAfraid:feature/integration/sse into d16f498 on 99designs:master.

@coveralls
Copy link

coveralls commented Jun 14, 2023 •
edited
Loading

Coverage Status

coverage: 79.113% (+3.2%) from 75.935% when pulling d8b6a3a on UnAfraid:feature/integration/sse into d16f498 on 99designs:master.

@StevenACoffman StevenACoffman added client GraphQL Client related federation Related to Apollo federation help wanted Extra attention is needed and removed help wanted Extra attention is needed federation Related to Apollo federation labels Jun 14, 2023
@StevenACoffman StevenACoffman merged commit d508082 into 99designs:master Jun 15, 2023
@UnAfraid UnAfraid deleted the feature/integration/sse branch June 15, 2023 18:34
@StevenACoffman StevenACoffman added the SSE Server-Sent Events label Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
client GraphQL Client related SSE Server-Sent Events
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UnAfraid @coveralls @StevenACoffman