Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testifylint v1.3.0 fixes #3103

Merged
merged 5 commits into from
May 27, 2024
Merged

testifylint v1.3.0 fixes #3103

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c732bcd
Resolve Merge conflict
alexandear May 27, 2024
6437db4
Autofixes
StevenACoffman May 26, 2024
265204c
Lots more fixes and formatting
StevenACoffman May 27, 2024
bc0a420
Add one more
StevenACoffman May 27, 2024
7dddf3b
Apply suggestions from code review
StevenACoffman May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Resolve Merge conflict 
Signed-off-by: Steve Coffman <steve@khanacademy.org>
  • Loading branch information
@alexandear @StevenACoffman
alexandear authored and StevenACoffman committed May 27, 2024
commit c732bcdecad5c81c72a373287acd808bdcf6c148
13 changes: 7 additions & 6 deletions graphql/handler/extension/apq_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,10 @@ func TestAPQ(t *testing.T) {
params := &graphql.RawParams{
Query: "original query",
}
err := extension.AutomaticPersistedQuery{graphql.MapCache{}}.MutateOperationParameters(ctx, params)
require.Equal(t, (*gqlerror.Error)(nil), err)

err := extension.AutomaticPersistedQuery{Cache: graphql.MapCache{}}.MutateOperationParameters(ctx, params)

require.Equal(t, (*gqlerror.Error)(nil), err)
require.Equal(t, "original query", params.Query)
})

Expand All @@ -60,7 +61,7 @@ func TestAPQ(t *testing.T) {
},
}

err := extension.AutomaticPersistedQuery{graphql.MapCache{}}.MutateOperationParameters(ctx, params)
err := extension.AutomaticPersistedQuery{Cache: graphql.MapCache{}}.MutateOperationParameters(ctx, params)
require.Equal(t, "PersistedQueryNotFound", err.Message)
})

Expand All @@ -76,9 +77,9 @@ func TestAPQ(t *testing.T) {
},
}
cache := graphql.MapCache{}
err := extension.AutomaticPersistedQuery{cache}.MutateOperationParameters(ctx, params)
require.Equal(t, (*gqlerror.Error)(nil), err)
err := extension.AutomaticPersistedQuery{Cache: cache}.MutateOperationParameters(ctx, params)

require.Equal(t, (*gqlerror.Error)(nil), err)
require.Equal(t, "{ me { name } }", params.Query)
require.Equal(t, "{ me { name } }", cache[hash])
})
Expand Down Expand Up @@ -116,8 +117,8 @@ func TestAPQ(t *testing.T) {
hash: query,
}
err := extension.AutomaticPersistedQuery{cache}.MutateOperationParameters(ctx, params)
require.Equal(t, (*gqlerror.Error)(nil), err)

require.Equal(t, (*gqlerror.Error)(nil), err)
require.Equal(t, "{ me { name } }", params.Query)
})

Expand Down
1 change: 0 additions & 1 deletion graphql/handler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ func TestAddUploadToOperations(t *testing.T) {
path := "variables.req.0.file"
err := request.AddUpload(upload, key, path)
require.Equal(t, (*gqlerror.Error)(nil), err)

require.Equal(t, expected, request)
})
}
2 changes: 1 addition & 1 deletion internal/code/packages_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ func initialState(t *testing.T, opts ...Option) *Packages {
"github.com/99designs/gqlgen/internal/code/testdata/a",
"github.com/99designs/gqlgen/internal/code/testdata/b",
)
require.Empty(t, p.Errors())

require.Empty(t, p.Errors())
require.Equal(t, 1, p.numLoadCalls)
require.Equal(t, 0, p.numNameCalls)
require.Equal(t, "a", pkgs[0].Name)
Expand Down