Bug in GetFullPath(basePath, Path) (dotnet#16598)

* GetFullPath and GetRootLength Corrected * Removed getpathroot * using span * "\\" changed to @"\"
A-And · Feb 28, 2018 · 686efaf · 686efaf
1 parent a3aa841
commit 686efaf
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/mscorlib/shared/System/IO/Path.Windows.cs b/src/mscorlib/shared/System/IO/Path.Windows.cs
@@ -98,8 +98,8 @@ public static string GetFullPath(string path, string basePath)
                 {
                     // No matching root, root to specified drive
                     // "D:Foo" and "C:\Bar" => "D:Foo"
-                    // "D:\Foo" and "\\?\C:\Bar" => "\\?\D:\Foo"
-                    combinedPath = path.Insert(2, "\\");
+                    // "D:Foo" and "\\?\C:\Bar" => "\\?\D:\Foo"
+                    combinedPath = PathInternal.IsDevice(basePath) ? CombineNoChecksInternal(basePath.AsSpan().Slice(0, 4), path.AsSpan().Slice(0, 2), @"\", path.AsSpan().Slice(2)) : path.Insert(2, "\\");
                 }
             }
             else