Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework EDM4hep output action #887

Merged
merged 4 commits into from
Dec 16, 2021
Merged

Rework EDM4hep output action #887

merged 4 commits into from
Dec 16, 2021

Commits on Dec 7, 2021

  1. Use auto where possible to avoid explicitly mentioning edm4hep types

    @tmadlener
    tmadlener committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    442c864 View commit details
    Browse the repository at this point in the history

  2. Use map to keep track of collections and avoid const_cast

    @tmadlener
    tmadlener committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    3f12c7d View commit details
    Browse the repository at this point in the history

  3. Switch to range based for loops where possible

    @tmadlener
    tmadlener committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    8110745 View commit details
    Browse the repository at this point in the history

  4. Set daugther relations as well 

    This doesn't happen automatically in EDM4hep but does in LCIO!
    @tmadlener
    tmadlener committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    d929413 View commit details
    Browse the repository at this point in the history