Remove unnecessary dictionary generation for I/O interfaces

AIDASoft · Jun 11, 2024 · faaa03a · faaa03a
1 parent a977956
commit faaa03a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 13 deletions.
diff --git a/include/podio/Reader.h b/include/podio/Reader.h
@@ -7,8 +7,7 @@
 namespace podio {
 
 class Reader {
-public:
-  // ROOT dictionary generation needs this to be public for some reason
+private:
   struct ReaderConcept {
     virtual ~ReaderConcept() = default;
 

diff --git a/include/podio/Writer.h b/include/podio/Writer.h
@@ -6,8 +6,7 @@
 namespace podio {
 
 class Writer {
-public:
-  // ROOT dictionary generation needs this to be public for some reason
+private:
   struct WriterConcept {
     virtual ~WriterConcept() = default;
 

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -148,7 +148,11 @@ set(io_headers
   ${PROJECT_SOURCE_DIR}/include/podio/Reader.h
   )
 
-PODIO_ADD_LIB_AND_DICT(podioIO "${io_headers}" "${io_sources}" io_selection.xml)
+add_library(podioIO SHARED ${io_sources})
+add_library(podio::podioIO ALIAS podioIO)
+target_include_directories(podioIO PUBLIC
+    $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include>
+    $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>)
 target_link_libraries(podioIO PUBLIC podio::podio podio::podioRootIO)
 if(ENABLE_SIO)
   target_link_libraries(podioIO PUBLIC podio::podioSioIO)
@@ -172,8 +176,6 @@ install(FILES
   ${CMAKE_CURRENT_BINARY_DIR}/libpodioDict_rdict.pcm
   ${CMAKE_CURRENT_BINARY_DIR}/podioRootIODictDict.rootmap
   ${CMAKE_CURRENT_BINARY_DIR}/libpodioRootIODict_rdict.pcm
-  ${CMAKE_CURRENT_BINARY_DIR}/podioIODictDict.rootmap
-  ${CMAKE_CURRENT_BINARY_DIR}/libpodioIODict_rdict.pcm
   DESTINATION "${CMAKE_INSTALL_LIBDIR}")
 
 if (ENABLE_SIO)

diff --git a/src/io_selection.xml b/src/io_selection.xml