Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-v00-13-01 podio ROOT files can no longer be read with the RootReader #229

Closed
vvolkl opened this issue Oct 11, 2021 · 0 comments · Fixed by #232
Closed

pre-v00-13-01 podio ROOT files can no longer be read with the RootReader #229

vvolkl opened this issue Oct 11, 2021 · 0 comments · Fixed by #232

Comments

@vvolkl
Copy link
Contributor

vvolkl commented Oct 11, 2021

I only realize this now, but the changes introduced in #197 mean that old podio root files can no longer be read.

~/r/podio/build/tests (master)$ ./read
Error in <TTree::SetBranchAddress>: unknown branch -> CollectionTypeInfo
reading event 0
terminate called after throwing an instance of 'std::runtime_error'
  what():  No collection 'strings' is present in the EventStore
Aborted (core dumped)

This relates to the metadata discussion #86 but in this case concerns a change in how podio stores metadata on disk.

I think in this case it is worth to try to do some gymnastics to keep the backwards incompatibility - breaking existing data is even more to be avoided than breaking user interfaces.

@vvolkl vvolkl changed the title pre-v00-13-02 podio ROOT files can no longer be read with the RootReader pre-v00-13-01 podio ROOT files can no longer be read with the RootReader Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant