Make it possible read "old" podio files #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hegner
reviewed
Oct 11, 2021
src/ROOTReader.cc
Outdated
| createCollectionBranches(*collectionInfo); | ||
| delete collectionInfo; | ||
| } else { | ||
| std::cout << "Reading old-style file" << std::endl; |
There was a problem hiding this comment.
if you integrate that into any framework of decent size you will have no idea where this message comes from. maybe adding "PODIO" and the name of the file will help
There was a problem hiding this comment.
Ah yes, of course. Left over from testing.
tmadlener
force-pushed
the
fix-read-old-files
branch
from
a7931ca
to
a28618d
Compare
tmadlener
force-pushed
the
fix-read-old-files
branch
from
a28618d
to
d9f68ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
"CollectionInfoType"branch that as introduced there via other means and simply assume that all collections are proper collections (since subset collections didn't exist prior).SIOCollectionIDTableBlockto 0.2 and only read the subset collection bits when they are available.ENDRELEASENOTES
For SIO bumping the version only now, technically makes it possible to produce files that already use subset collections, but will not be able to read those back. However, I think there is no other way of encoding this information that doesn't break even earlier files.
Fixes #229