Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leaks in EventStore and Reader/Writer interplay #134

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Fix memory leaks in EventStore and Reader/Writer interplay #134

merged 3 commits into from
Sep 18, 2020

Conversation

tmadlener
Copy link
Collaborator

@tmadlener tmadlener commented Sep 7, 2020 •
edited
Loading

BEGINRELEASENOTES

ENDRELEASENOTES

The m_table pointer to the collection ID table is not deleted in the deconstructor even though it is acquired via new in the constructor. Using a unique_ptr to make clear that the EventStore owns this table (which it seems to do at least following the logic in setCollectionIDTable)

Fixes #139

This was referenced Sep 8, 2020
Merged
Merged
@tmadlener tmadlener changed the title Fix EventStore leaking the CollectionIDTable Fix memory leaks in EventStore and Reader/Writer interplay Sep 18, 2020
@tmadlener tmadlener mentioned this pull request Sep 18, 2020
Closed
@tmadlener
Clean up VectorMember data properly in collections
11af492 
If an Obj with VectorMembers is added to a collection, it becomes
tracked and hence will no longer delete the vector member pointer. It
is, thus the collections responsibility to do this in order to avoid
leaking this.
@hegner
Copy link
Collaborator

hegner commented Sep 18, 2020

Thanks! Nice work. Let's wait for the tests for the final review

@hegner hegner self-requested a review September 18, 2020 13:47
@hegner
Copy link
Collaborator

hegner commented Sep 18, 2020

expected that the Mac test fails?

@tmadlener
Copy link
Collaborator Author

expected that the Mac test fails?

Not really, but this one is still related to #137 and is only related to the fact that github changed the mac virtual environment a few days ago and this no longer plays nicely with the root version we currently use.

@hegner hegner merged commit 2531527 into AIDASoft:master Sep 18, 2020
@tmadlener tmadlener deleted the fix-eventstore-memory-leak branch September 22, 2020 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hegner hegner hegner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reading and writing events leaks memory
2 participants
@tmadlener @hegner